Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2903173003: Removed -[CRWWebDelegate webWillReload] callback. (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index eb50be699333e52e7c03c2cd1353513ece43241e..a86f1374b8835774493a7889dab9850cfed5bd95 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -985,11 +985,6 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
currentIndex:sessionTab->current_navigation_index];
}
-- (void)webWillReload {
- if ([_parentTabModel tabUsageRecorder])
- [_parentTabModel tabUsageRecorder]->RecordReload(self);
-}
-
// Halt the tab, which amounts to halting its webController.
- (void)terminateNetworkActivity {
[self.webController terminateNetworkActivity];
@@ -1408,6 +1403,12 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
- (void)webState:(web::WebState*)webState
didStartNavigation:(web::NavigationContext*)navigation {
+ if ([_parentTabModel tabUsageRecorder] &&
+ PageTransitionCoreTypeIs(navigation->GetPageTransition(),
+ ui::PAGE_TRANSITION_RELOAD)) {
+ [_parentTabModel tabUsageRecorder]->RecordReload(self);
+ }
+
[self.dialogDelegate cancelDialogForTab:self];
[_parentTabModel notifyTabChanged:self];
[_openInController disable];
« no previous file with comments | « no previous file | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698