Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2903173002: Closing simulation window in chromeos sessions causes crash. (Closed)

Created:
3 years, 7 months ago by thanhph
Modified:
3 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, varkha
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Closing simulation window in chromeos sessions causes crash. This happens because pointer window_element_root_ wasn't initialized before being used but later got cleaned up in Reset(). BUG=698276 Review-Url: https://codereview.chromium.org/2903173002 Cr-Commit-Position: refs/heads/master@{#474763} Committed: https://chromium.googlesource.com/chromium/src/+/f2fa35501fc24beeec974e3e4638c17ad27de44c

Patch Set 1 #

Patch Set 2 : use std::unique_ptr for window_element_root_. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M ash/devtools/ash_devtools_dom_agent.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/devtools/ash_devtools_dom_agent.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
thanhph
Hi Sadrul, Please review my patch. Thanks, Thanh.
3 years, 7 months ago (2017-05-25 19:09:05 UTC) #12
sadrul
lgtm
3 years, 7 months ago (2017-05-25 19:40:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903173002/20001
3 years, 7 months ago (2017-05-25 19:48:17 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 19:53:45 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f2fa35501fc24beeec974e3e4638...

Powered by Google App Engine
This is Rietveld 408576698