Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2037)

Unified Diff: ash/devtools/ash_devtools_dom_agent.h

Issue 2903173002: Closing simulation window in chromeos sessions causes crash. (Closed)
Patch Set: use std::unique_ptr for window_element_root_. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/devtools/ash_devtools_dom_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/devtools/ash_devtools_dom_agent.h
diff --git a/ash/devtools/ash_devtools_dom_agent.h b/ash/devtools/ash_devtools_dom_agent.h
index 91074fb1452c5cc60b6171821c8b172a82c646bf..0569f840c89d3328bab42ab3d0c724ca9a3b41d1 100644
--- a/ash/devtools/ash_devtools_dom_agent.h
+++ b/ash/devtools/ash_devtools_dom_agent.h
@@ -56,7 +56,7 @@ class ASH_EXPORT AshDevToolsDOMAgent
void AddObserver(AshDevToolsDOMAgentObserver* observer);
void RemoveObserver(AshDevToolsDOMAgentObserver* observer);
UIElement* GetElementFromNodeId(int node_id);
- UIElement* window_element_root() const { return window_element_root_; };
+ UIElement* window_element_root() const { return window_element_root_.get(); };
private:
void OnNodeBoundsChanged(int node_id);
@@ -86,7 +86,7 @@ class ASH_EXPORT AshDevToolsDOMAgent
int node_id);
bool is_building_tree_;
- UIElement* window_element_root_;
+ std::unique_ptr<UIElement> window_element_root_;
std::unordered_map<int, UIElement*> node_id_to_ui_element_;
std::unique_ptr<views::Widget> widget_for_highlighting_;
base::ObserverList<AshDevToolsDOMAgentObserver> observers_;
« no previous file with comments | « no previous file | ash/devtools/ash_devtools_dom_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698