Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2903133003: Revert of Unify webexposed/global-interface-listing scripts (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
jsbell, foolip
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, mac-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik, ikilpatrick
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Unify webexposed/global-interface-listing scripts (patchset #4 id:60001 of https://codereview.chromium.org/2889423003/ ) Reason for revert: Broke SystemWebViewShellLayoutTest. crbug.com/726196 Original issue's description: > Unify webexposed/global-interface-listing scripts > > Refactor and relocate the script we use to enumerate global interfaces > and their properties into a library so that it can be used by both > windows, dedicated/shared/compositor workers, and service workers. > > (Worklets still have their own copy in http/tests/worklet/webexposed) > > Review-Url: https://codereview.chromium.org/2889423003 > Cr-Commit-Position: refs/heads/master@{#474339} > Committed: https://chromium.googlesource.com/chromium/src/+/5bc093f718e75a916497b04bc379d4404021b55c TBR=foolip@chromium.org,jsbell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2903133003 Cr-Commit-Position: refs/heads/master@{#474545} Committed: https://chromium.googlesource.com/chromium/src/+/4e58cf4b5a9ff2a3e20e65d984a03f6670cce5e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -604 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 55 chunks +1 line, -111 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/resources/global-interface-listing-worker.js View 1 chunk +131 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/resources/global-interface-listing-worklet.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 38 chunks +1 line, -78 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/resources/global-interface-listing.js View 1 chunk +0 lines, -160 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 54 chunks +1 line, -110 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 38 chunks +1 line, -78 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/webexposed/resources/global-interface-listing.js View 1 chunk +188 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/webexposed/resources/global-interface-listing-worker.js View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
wychen
Created Revert of Unify webexposed/global-interface-listing scripts
3 years, 7 months ago (2017-05-25 04:05:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903133003/1
3 years, 7 months ago (2017-05-25 04:06:10 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 04:07:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4e58cf4b5a9ff2a3e20e65d984a0...

Powered by Google App Engine
This is Rietveld 408576698