Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2889423003: Unify webexposed/global-interface-listing scripts (Closed)

Created:
3 years, 7 months ago by jsbell
Modified:
3 years, 7 months ago
Reviewers:
foolip, timvolodine
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, mac-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik, ikilpatrick
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify webexposed/global-interface-listing scripts Refactor and relocate the script we use to enumerate global interfaces and their properties into a library so that it can be used by both windows, dedicated/shared/compositor workers, and service workers. (Worklets still have their own copy in http/tests/worklet/webexposed) Review-Url: https://codereview.chromium.org/2889423003 Cr-Original-Commit-Position: refs/heads/master@{#474339} Committed: https://chromium.googlesource.com/chromium/src/+/5bc093f718e75a916497b04bc379d4404021b55c Review-Url: https://codereview.chromium.org/2889423003 Cr-Commit-Position: refs/heads/master@{#475031} Committed: https://chromium.googlesource.com/chromium/src/+/8aebbaa46a1af6f69ae64005cc7c04da4c367547

Patch Set 1 #

Patch Set 2 : Update some platform/virtual expectations #

Patch Set 3 : Rebased #

Patch Set 4 : Try a manual baseline update for mac #

Patch Set 5 : Update reference to moved script #

Patch Set 6 : Speculative rebase #

Patch Set 7 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -384 lines) Patch
M android_webview/tools/system_webview_shell/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 56 chunks +111 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/resources/global-interface-listing-worker.js View 1 chunk +11 lines, -131 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/resources/global-interface-listing-worklet.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 38 chunks +79 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/resources/global-interface-listing.js View 5 chunks +13 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 55 chunks +110 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 38 chunks +79 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/webexposed/resources/global-interface-listing.js View 1 chunk +0 lines, -188 lines 0 comments Download
A third_party/WebKit/LayoutTests/webexposed/resources/global-interface-listing-worker.js View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 41 (24 generated)
jsbell
foolip@ - please take a look? I'm still learning about worklets here; looks like the ...
3 years, 7 months ago (2017-05-19 21:38:42 UTC) #4
jsbell
cc: ikilpatrick re: worklets
3 years, 7 months ago (2017-05-19 21:40:50 UTC) #5
jsbell
FYI, it appears that worklet.addModule() will currently import a script which is then evaluated in ...
3 years, 7 months ago (2017-05-19 23:42:15 UTC) #8
jsbell
Talked w/ ikilpatrick offline; module support is coming Real Soon Now so don't want to ...
3 years, 7 months ago (2017-05-23 18:04:22 UTC) #10
jsbell
Okay, I think I made the bots happy... foolip@ - how does this look?
3 years, 7 months ago (2017-05-23 22:18:20 UTC) #11
foolip
lgtm
3 years, 7 months ago (2017-05-24 11:57:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889423003/60001
3 years, 7 months ago (2017-05-24 15:59:12 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/5bc093f718e75a916497b04bc379d4404021b55c
3 years, 7 months ago (2017-05-24 17:35:32 UTC) #17
wychen
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2903133003/ by wychen@chromium.org. ...
3 years, 7 months ago (2017-05-25 04:05:34 UTC) #18
jsbell
timvolodine@ - can you review the android_webview/tools/system_webview_shell/BUILD.gn update?
3 years, 7 months ago (2017-05-25 17:30:46 UTC) #23
timvolodine
On 2017/05/25 17:30:46, jsbell wrote: > timvolodine@ - can you review the > android_webview/tools/system_webview_shell/BUILD.gn update? ...
3 years, 7 months ago (2017-05-25 17:42:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889423003/100001
3 years, 7 months ago (2017-05-25 19:50:12 UTC) #29
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt: While running git apply --index -3 -p1; error: patch ...
3 years, 7 months ago (2017-05-25 22:41:01 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889423003/120001
3 years, 7 months ago (2017-05-25 23:38:24 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/303704)
3 years, 7 months ago (2017-05-26 04:35:14 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889423003/120001
3 years, 7 months ago (2017-05-26 15:56:25 UTC) #38
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 16:45:14 UTC) #41
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/8aebbaa46a1af6f69ae64005cc7c...

Powered by Google App Engine
This is Rietveld 408576698