Chromium Code Reviews
DescriptionReland "Add metrics for search engine promo and search widget"
Reason for revert:
already fixed downstream in https://chrome-internal-review.googlesource.com/380388
> Revert "Add metrics for search engine promo and search widget"
>
> This reverts commit d307666724e1a3a49943b035271723135be40829.
>
> Reason for revert:
> broke clank_junit_tests. crbug.com/726061
>
> Original issue's description:
> > Add metrics for search engine promo and search widget
> >
> > - Adds histograms and user action for search widget use
> > - Add histogram definitions around search engine promo use and
> > selections
> > - Add LocaleManager refactoring to route the signals that are important
> > for metrics
> >
> > BUG=724349, 724348
> > Review-Url: https://codereview.chromium.org/2898823002
> > Cr-Commit-Position: refs/heads/master@{#474203}
> > Committed: https://chromium.googlesource.com/chromium/src/+/d307666724e1a3a49943b035271723135be40829
>
> TBR=yusufo@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=726061
>
> Review-Url: https://codereview.chromium.org/2897363003
> Cr-Commit-Position: refs/heads/master@{#474404}
TBR=yusufo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=726061
Review-Url: https://codereview.chromium.org/2902913003
Cr-Commit-Position: refs/heads/master@{#474428}
Committed: https://chromium.googlesource.com/chromium/src/+/9e6c29b66c4e874eaad2c690bc085f43780cd4f2
Patch Set 1 #Messages
Total messages: 6 (4 generated)
|