Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2897363003: Revert "Add metrics for search engine promo and search widget" (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, jdonnelly+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add metrics for search engine promo and search widget" This reverts commit d307666724e1a3a49943b035271723135be40829. Reason for revert: broke clank_junit_tests. crbug.com/726061 Original issue's description: > Add metrics for search engine promo and search widget > > - Adds histograms and user action for search widget use > - Add histogram definitions around search engine promo use and > selections > - Add LocaleManager refactoring to route the signals that are important > for metrics > > BUG=724349, 724348 > Review-Url: https://codereview.chromium.org/2898823002 > Cr-Commit-Position: refs/heads/master@{#474203} > Committed: https://chromium.googlesource.com/chromium/src/+/d307666724e1a3a49943b035271723135be40829 TBR=yusufo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=726061 Review-Url: https://codereview.chromium.org/2897363003 Cr-Commit-Position: refs/heads/master@{#474404} Committed: https://chromium.googlesource.com/chromium/src/+/c85db9e48e29888204b45335c1b0e309441d2f8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -250 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelper.java View 4 chunks +6 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 5 chunks +2 lines, -58 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/android/locale/locale_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/locale/locale_manager.cc View 2 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M components/search_engines/BUILD.gn View 2 chunks +0 lines, -12 lines 0 comments Download
M components/search_engines/search_engine_type.h View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/metrics/actions/actions.xml View 3 chunks +0 lines, -32 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 2 chunks +0 lines, -13 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -61 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897363003/1
3 years, 7 months ago (2017-05-24 20:36:19 UTC) #2
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 20:37:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c85db9e48e29888204b45335c1b0...

Powered by Google App Engine
This is Rietveld 408576698