Enable the new Incognito NTP

Enable the new Incognito NTP

It was developed behind an experimental flag, but has been finished and
approved by the UI review. This CL still leaves the flag in until the
feature is fully launched, for easy disabling if necessary.

BUG=693525
Review-Url: https://codereview.chromium.org/2902843002
Cr-Commit-Position: refs/heads/master@{#474384}
Committed: https://chromium.googlesource.com/chromium/src/+/a8852f2672df3b8c9f1daeadbcee5243191de8f5

[msramek, 2017-05-23 20:12:22]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 20:13:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-05-23 20:13:53]

msramek@chromium.org changed reviewers:
+ engedy@chromium.org

[msramek, 2017-05-23 20:13:54]

Hi Balázs,

Can you have a quick look? No context needed :)

Thanks,
Martin

[engedy, 2017-05-23 20:43:48]

Pinky swear that the feature is cool? If so, LGTM. :)

[commit-bot: I haz the power, 2017-05-23 22:16:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 22:16:16]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[msramek, 2017-05-24 17:53:16]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 17:54:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-05-24 17:55:21]

Thanks!

Would you mind having another look though? In
https://codereview.chromium.org/2902013002/ I already started developing the
feature on Android, thus this CL should only enable it on Desktop.

Weird formatting courtesy of clang-format.

[engedy, 2017-05-24 18:01:28]

Still LGTM. You do have it already implemented on *all* other platforms, right?
Just wondering if a whitelist approach would be better

[msramek, 2017-05-24 18:06:13]

Thanks again!

The OS of this Feature is defined as kOsAll = kOsMac | kOsWin | kOsLinux |
kOsCrOS | kOsAndroid.

The Desktops share one implementation, so Android is really the only one
disabled.

[engedy, 2017-05-24 18:09:18]

On 2017/05/24 18:06:13, msramek wrote:
> Thanks again!
> 
> The OS of this Feature is defined as kOsAll = kOsMac | kOsWin | kOsLinux |
> kOsCrOS | kOsAndroid.
> 
> The Desktops share one implementation, so Android is really the only one
> disabled.

SGTM.

[msramek, 2017-05-24 19:11:58]

The CQ bit was unchecked by msramek@chromium.org

[msramek, 2017-05-24 19:12:04]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:12:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 19:17:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495653124093610,
"parent_rev": "dc44616c932d390c6ee11c2eb5931d51e7df91a7", "commit_rev":
"a8852f2672df3b8c9f1daeadbcee5243191de8f5"}

[commit-bot: I haz the power, 2017-05-24 19:17:40]

Description was changed from

==========
Enable the new Incognito NTP

It was developed behind an experimental flag, but has been finished and
approved by the UI review. This CL still leaves the flag in until the
feature is fully launched, for easy disabling if necessary.

BUG=693525
==========

to

==========
Enable the new Incognito NTP

It was developed behind an experimental flag, but has been finished and
approved by the UI review. This CL still leaves the flag in until the
feature is fully launched, for easy disabling if necessary.

BUG=693525

Review-Url: https://codereview.chromium.org/2902843002
Cr-Commit-Position: refs/heads/master@{#474384}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8852f2672df3b8c9f1daeadbcee...
==========

[commit-bot: I haz the power, 2017-05-24 19:17:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a8852f2672df3b8c9f1daeadbcee...