Implement a sketch of the new MD Incognito NTP on Android

Implement a sketch of the new MD Incognito NTP on Android

This CL introduces:
- A feature flag for the new Incognito NTP on Android
- A new FrameLayout for this page (XML + Java)
- Reuses the HTML-formatted strings from the new Desktop Incognito NTP

The CL only contains structural changes; it is not yet styled to match
the spec (https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI)

BUG=693525
Review-Url: https://codereview.chromium.org/2902013002
Cr-Commit-Position: refs/heads/master@{#474381}
Committed: https://chromium.googlesource.com/chromium/src/+/acd48bf956b4bf7de6702c20ebdbe83132a2be8c

[msramek, 2017-05-23 20:55:25]

Description was changed from

==========
Implement a sketch of the new MD Incognito NTP on Android

This CL introduces:
- A feature flag for the new Incognito NTP on Android
- A new FrameLayout for this page (XML + Java)
- Reuses the HTML-formatted strings from the new Desktop Incognito NTP

The CL only contains structural changes; it does not yet styled to match
the spec (https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI)

BUG=693525
==========

to

==========
Implement a sketch of the new MD Incognito NTP on Android

This CL introduces:
- A feature flag for the new Incognito NTP on Android
- A new FrameLayout for this page (XML + Java)
- Reuses the HTML-formatted strings from the new Desktop Incognito NTP

The CL only contains structural changes; it is not yet styled to match
the spec (https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI)

BUG=693525
==========

[msramek, 2017-05-23 20:56:06]

msramek@chromium.org changed reviewers:
+ twellington@chromium.org

[msramek, 2017-05-23 20:56:06]

Hi Theresa,

Please have a look!

I didn't want to send a huge CL at once, so this is just a sketch. I would
mostly like to hear if I got the structure right before going forward with
polishing the UI :)

Thanks!
Martin

[msramek, 2017-05-23 20:56:13]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 20:56:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-05-23 21:32:47]

msramek@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[msramek, 2017-05-23 21:32:47]

...and somehow I missed that while you own a lot of the Android UI, not the NTP
in particular. Sorry!

Passing to +Michael - please have a look!

[commit-bot: I haz the power, 2017-05-24 00:43:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 00:43:02]

Dry run: This issue passed the CQ dry run.

[Michael van Ouwerkerk, 2017-05-24 16:16:00]

Could you share a screenshot of the UI this CL creates please?

https://codereview.chromium.org/2902013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
(right):

https://codereview.chromium.org/2902013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java:81:
private boolean useMDIncognitoNTP() {
nit: this could be static

https://codereview.chromium.org/2902013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java
(right):

https://codereview.chromium.org/2902013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java:45:
private void populateBulletpoints(int element, int content) {
nit: @IdRes and @StringRes

[msramek, 2017-05-24 16:30:12]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 16:30:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-05-24 16:32:53]

I attached screenshots to the linked bug (crbug.com/693525).

They're currently:
- Misaligned
- Missing bulletpoints graphics
- Missing correct padding/margins

(but of course, all is behind the flag)

https://codereview.chromium.org/2902013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
(right):

https://codereview.chromium.org/2902013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java:81:
private boolean useMDIncognitoNTP() {
On 2017/05/24 16:16:00, Michael van Ouwerkerk wrote:
> nit: this could be static

Done.

https://codereview.chromium.org/2902013002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java
(right):

https://codereview.chromium.org/2902013002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java:45:
private void populateBulletpoints(int element, int content) {
On 2017/05/24 16:16:00, Michael van Ouwerkerk wrote:
> nit: @IdRes and @StringRes

Done.

[Michael van Ouwerkerk, 2017-05-24 16:34:36]

Thanks! lgtm

[msramek, 2017-05-24 16:36:51]

Thank you!

[msramek, 2017-05-24 16:36:58]

The CQ bit was unchecked by msramek@chromium.org

[msramek, 2017-05-24 16:37:03]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2017-05-24 16:37:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 19:10:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495643823330740,
"parent_rev": "1290776535cfda1fa1cd7867d5a2ae2ded7e92ec", "commit_rev":
"acd48bf956b4bf7de6702c20ebdbe83132a2be8c"}

[commit-bot: I haz the power, 2017-05-24 19:10:27]

Description was changed from

==========
Implement a sketch of the new MD Incognito NTP on Android

This CL introduces:
- A feature flag for the new Incognito NTP on Android
- A new FrameLayout for this page (XML + Java)
- Reuses the HTML-formatted strings from the new Desktop Incognito NTP

The CL only contains structural changes; it is not yet styled to match
the spec (https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI)

BUG=693525
==========

to

==========
Implement a sketch of the new MD Incognito NTP on Android

This CL introduces:
- A feature flag for the new Incognito NTP on Android
- A new FrameLayout for this page (XML + Java)
- Reuses the HTML-formatted strings from the new Desktop Incognito NTP

The CL only contains structural changes; it is not yet styled to match
the spec (https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI)

BUG=693525

Review-Url: https://codereview.chromium.org/2902013002
Cr-Commit-Position: refs/heads/master@{#474381}
Committed:
https://chromium.googlesource.com/chromium/src/+/acd48bf956b4bf7de6702c20ebdb...
==========

[commit-bot: I haz the power, 2017-05-24 19:10:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/acd48bf956b4bf7de6702c20ebdb...