Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2902823003: Revert of ServiceWorker: Keep info as a member of ServiceWorkerProviderHost (Closed)

Created:
3 years, 7 months ago by shimazu
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ServiceWorker: Keep info as a member of ServiceWorkerProviderHost (patchset #3 id:40001 of https://codereview.chromium.org/2891903002/ ) Reason for revert: This seems causing crashes. See also https://crbug.com/725416. Original issue's description: > ServiceWorker: Keep info as a member of ServiceWorkerProviderHost > > This patch is to use SWProviderHostInfo as an argument of ctor of > SWProviderHost. SWProvider directly keeps the passed SWProviderHostInfo as a > member. > > This patch split off from https://crrev.com/2653493009. > > BUG=N/A > > Review-Url: https://codereview.chromium.org/2891903002 > Cr-Commit-Position: refs/heads/master@{#473166} > Committed: https://chromium.googlesource.com/chromium/src/+/b8f57b211d1293781ceac7cc9650983b668cf917 TBR=falken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=N/A Review-Url: https://codereview.chromium.org/2902823003 Cr-Commit-Position: refs/heads/master@{#474206} Committed: https://chromium.googlesource.com/chromium/src/+/e296b2b02fe6997bd09faca1b4efb86f3158c90e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -49 lines) Patch
M content/browser/service_worker/service_worker_provider_host.h View 5 chunks +16 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 12 chunks +36 lines, -27 lines 0 comments Download
M content/common/service_worker/service_worker_provider_host_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/service_worker/service_worker_provider_host_info.cc View 1 chunk +2 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
shimazu
Created Revert of ServiceWorker: Keep info as a member of ServiceWorkerProviderHost
3 years, 7 months ago (2017-05-24 02:28:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902823003/1
3 years, 7 months ago (2017-05-24 02:30:19 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/301569)
3 years, 7 months ago (2017-05-24 06:42:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902823003/1
3 years, 7 months ago (2017-05-24 06:55:55 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 08:03:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e296b2b02fe6997bd09faca1b4ef...

Powered by Google App Engine
This is Rietveld 408576698