Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2891903002: ServiceWorker: Keep info as a member of ServiceWorkerProviderHost (Closed)

Created:
3 years, 7 months ago by shimazu
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Keep info as a member of ServiceWorkerProviderHost This patch is to use SWProviderHostInfo as an argument of ctor of SWProviderHost. SWProvider directly keeps the passed SWProviderHostInfo as a member. This patch split off from https://crrev.com/2653493009. BUG=N/A Review-Url: https://codereview.chromium.org/2891903002 Cr-Commit-Position: refs/heads/master@{#473166} Committed: https://chromium.googlesource.com/chromium/src/+/b8f57b211d1293781ceac7cc9650983b668cf917

Patch Set 1 #

Patch Set 2 : Initialized SWProviderHostInfo #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -52 lines) Patch
M content/browser/service_worker/service_worker_provider_host.h View 1 2 5 chunks +8 lines, -16 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 2 12 chunks +25 lines, -34 lines 0 comments Download
M content/common/service_worker/service_worker_provider_host_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/service_worker/service_worker_provider_host_info.cc View 1 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
shimazu
ptal, thanks!
3 years, 7 months ago (2017-05-18 10:32:51 UTC) #7
falken
nice, lgtm
3 years, 7 months ago (2017-05-19 06:42:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891903002/20001
3 years, 7 months ago (2017-05-19 08:32:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/442237)
3 years, 7 months ago (2017-05-19 08:40:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891903002/40001
3 years, 7 months ago (2017-05-19 08:58:40 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/b8f57b211d1293781ceac7cc9650983b668cf917
3 years, 7 months ago (2017-05-19 12:19:34 UTC) #20
shimazu
3 years, 7 months ago (2017-05-24 02:28:42 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2902823003/ by shimazu@chromium.org.

The reason for reverting is: This seems causing crashes.
See also https://crbug.com/725416..

Powered by Google App Engine
This is Rietveld 408576698