Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Issue 2902773002: Add V8 shared array allocation sizes histogram. (Closed)

Created:
3 years, 7 months ago by kschimpf
Modified:
3 years, 6 months ago
Reviewers:
bbudge, Ilya Sherman
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Add V8 shared array allocation sizes histogram. Add histogram to track sizes of share array buffers in Wasm/Js. Associated with Chrome CL: https://codereview.chromium.org/2898953003 BUG=chromium:725309 Review-Url: https://codereview.chromium.org/2902773002 Cr-Commit-Position: refs/heads/master@{#45577} Committed: https://chromium.googlesource.com/v8/v8/+/86f95d87b946173baeee87c35d1765308b5012e0

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/counters.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (26 generated)
kschimpf
Please review. Thanks!
3 years, 7 months ago (2017-05-26 15:40:06 UTC) #24
Ilya Sherman
LGTM, thanks.
3 years, 7 months ago (2017-05-26 22:10:43 UTC) #25
bbudge
lgtm
3 years, 7 months ago (2017-05-26 22:13:55 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902773002/20001
3 years, 6 months ago (2017-05-29 16:49:09 UTC) #28
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 18:19:41 UTC) #31
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/86f95d87b946173baeee87c35d1765308b5...

Powered by Google App Engine
This is Rietveld 408576698