Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2898953003: Add V8 shared array allocation sizes histogram. (Closed)

Created:
3 years, 7 months ago by kschimpf
Modified:
3 years, 6 months ago
Reviewers:
bbudge, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add V8 shared array allocation sizes histogram. Add histogram to track sizes of shared array buffers in JS. Associated with V8 CL: https://codereview.chromium.org/2902773002 BUG=chromium:725309 Review-Url: https://codereview.chromium.org/2898953003 Cr-Commit-Position: refs/heads/master@{#475198} Committed: https://chromium.googlesource.com/chromium/src/+/bec7087d3eb468bed72e4e39478edf7c57acf298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
kschimpf
Please review. Thanks!
3 years, 6 months ago (2017-05-26 15:40:57 UTC) #9
Ilya Sherman
LGTM, thanks.
3 years, 6 months ago (2017-05-26 22:10:41 UTC) #10
bbudge
lgtm
3 years, 6 months ago (2017-05-26 22:12:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898953003/1
3 years, 6 months ago (2017-05-26 22:49:36 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-27 01:26:29 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bec7087d3eb468bed72e4e39478e...

Powered by Google App Engine
This is Rietveld 408576698