Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2902723006: Measure the usage of <ol>.start with |reversed| and no |start| attribute. (Closed)

Created:
3 years, 7 months ago by Shanmuga Pandi
Modified:
3 years, 7 months ago
Reviewers:
tkent, Ilya Sherman, fs, foolip
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure the usage of <ol>.start with |reversed| and no |start| attribute. Add usecounter to measure the usage of <ol>.start which has |reversed| attribute and no |start| content attribute. BUG=657972 Review-Url: https://codereview.chromium.org/2902723006 Cr-Commit-Position: refs/heads/master@{#474614} Committed: https://chromium.googlesource.com/chromium/src/+/846987251c417048faef232c657c83da59715eae

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased and change the enum name #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOListElement.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOListElement.cpp View 1 1 chunk +14 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
Shanmuga Pandi
PTAL!!
3 years, 7 months ago (2017-05-24 12:44:04 UTC) #2
fs
lgtm
3 years, 7 months ago (2017-05-24 12:54:53 UTC) #3
Ilya Sherman
On 2017/05/24 12:44:04, Shanmuga Pandi wrote: > PTAL!! You don't need my review for the ...
3 years, 7 months ago (2017-05-24 15:43:41 UTC) #4
tkent
lgtm https://codereview.chromium.org/2902723006/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2902723006/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h#newcode1610 third_party/WebKit/Source/core/frame/UseCounter.h:1610: kHTMLOListElementReversedWithoutStart = 1998, kHTMLOListElementStartGetterReversedWithoutStartAttribute is more correct.
3 years, 7 months ago (2017-05-24 23:41:55 UTC) #9
Shanmuga Pandi
https://codereview.chromium.org/2902723006/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2902723006/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h#newcode1610 third_party/WebKit/Source/core/frame/UseCounter.h:1610: kHTMLOListElementReversedWithoutStart = 1998, On 2017/05/24 23:41:55, tkent wrote: > ...
3 years, 7 months ago (2017-05-25 06:04:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902723006/20001
3 years, 7 months ago (2017-05-25 06:05:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/218705) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-05-25 06:07:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902723006/40001
3 years, 7 months ago (2017-05-25 09:18:48 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 09:23:03 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/846987251c417048faef232c657c...

Powered by Google App Engine
This is Rietveld 408576698