third_party/WebKit/Source/core/html/HTMLOListElement.h - Issue 2902723006: Measure the usage of <ol>.start with |reversed| and no |start| attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLOListElement.h

Issue 2902723006: Measure the usage of <ol>.start with |reversed| and no |start| attribute. (Closed)

Patch Set: rebased Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLOListElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLOListElement.h b/third_party/WebKit/Source/core/html/HTMLOListElement.h

index 86eb3eba773b406509e78dedeadbf2ebdbb2d2c1..8c47330397aa00446b8a7a997004e447dbd35299 100644

--- a/third_party/WebKit/Source/core/html/HTMLOListElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLOListElement.h

@@ -33,9 +33,7 @@ class HTMLOListElement final : public HTMLElement {

public:

DECLARE_NODE_FACTORY(HTMLOListElement);

- int start() const {

- return has_explicit_start_ ? start_ : (is_reversed_ ? ItemCount() : 1);

- }

+ int start() const;

void setStart(int);

bool IsReversed() const { return is_reversed_; }