Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Issue 2902693002: Use base::Optional<int32_t> in H264POC::ComputePicOrderCnt(...) (Closed)

Created:
3 years, 7 months ago by Chandan
Modified:
3 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, mac-reviews_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::Optional<int32_t> in H264POC::ComputePicOrderCnt(...) This CL adds base::Optional<int32_t> return type for H264POC::ComputePicOrderCnt(...). BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2902693002 Cr-Commit-Position: refs/heads/master@{#473993} Committed: https://chromium.googlesource.com/chromium/src/+/ab17ae0f775e0ebcbd437ec23064eb0e8bb7bd7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -100 lines) Patch
M media/gpu/vt_video_decode_accelerator_mac.h View 1 chunk +0 lines, -6 lines 0 comments Download
M media/gpu/vt_video_decode_accelerator_mac.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M media/video/h264_poc.h View 1 chunk +3 lines, -7 lines 0 comments Download
M media/video/h264_poc.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M media/video/h264_poc_unittest.cc View 9 chunks +102 lines, -71 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Chandan
PTAL. Thank you.
3 years, 7 months ago (2017-05-23 11:44:30 UTC) #8
sandersd (OOO until July 31)
lgtm
3 years, 7 months ago (2017-05-23 18:10:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902693002/1
3 years, 7 months ago (2017-05-23 18:29:46 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 18:35:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab17ae0f775e0ebcbd437ec23064...

Powered by Google App Engine
This is Rietveld 408576698