Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: media/video/h264_poc.h

Issue 2902693002: Use base::Optional<int32_t> in H264POC::ComputePicOrderCnt(...) (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/gpu/vt_video_decode_accelerator_mac.cc ('k') | media/video/h264_poc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/h264_poc.h
diff --git a/media/video/h264_poc.h b/media/video/h264_poc.h
index 90d0eb904cf54b71cc85999cce42867b5501cee4..06a0dfd34119fb81359881e25c59f2b4cb6f2e76 100644
--- a/media/video/h264_poc.h
+++ b/media/video/h264_poc.h
@@ -19,13 +19,9 @@ class MEDIA_EXPORT H264POC {
H264POC();
~H264POC();
- // Compute the picture order count for a slice, storing the result into
- // |*pic_order_cnt|.
- // TODO(sandersd): Switch to a base::Optional<int32_t> return type.
- bool ComputePicOrderCnt(
- const H264SPS* sps,
- const H264SliceHeader& slice_hdr,
- int32_t* pic_order_cnt);
+ // Returns the picture order count for a slice.
+ base::Optional<int32_t> ComputePicOrderCnt(const H264SPS* sps,
+ const H264SliceHeader& slice_hdr);
// As specified, the POC of a frame with MMCO5 changes (to zero) after
// decoding. We instead return 0 immediately, and flag that this has occurred
« no previous file with comments | « media/gpu/vt_video_decode_accelerator_mac.cc ('k') | media/video/h264_poc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698