Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2902453003: Remove DownloadController java weak reference (Closed)

Created:
3 years, 7 months ago by qinmin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DownloadController java weak reference All DownloadController java method can be static. So there is no point to hold a java reference. Review-Url: https://codereview.chromium.org/2902453003 Cr-Commit-Position: refs/heads/master@{#473722} Committed: https://chromium.googlesource.com/chromium/src/+/e009d5fc3e329c2822ab06f415edbd35d2779ad1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -90 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java View 10 chunks +8 lines, -19 lines 0 comments Download
M chrome/browser/android/download/download_controller.h View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/android/download/download_controller.cc View 11 chunks +12 lines, -62 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qinmin
PTAL
3 years, 7 months ago (2017-05-22 20:12:01 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-05-22 21:20:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902453003/1
3 years, 7 months ago (2017-05-22 21:21:40 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 22:13:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e009d5fc3e329c2822ab06f415ed...

Powered by Google App Engine
This is Rietveld 408576698