Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/browser/android/download/download_controller.h

Issue 2902453003: Remove DownloadController java weak reference (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/download/download_controller.h
diff --git a/chrome/browser/android/download/download_controller.h b/chrome/browser/android/download/download_controller.h
index d085160a39f2f8502579524d00edb52eb5b8e3a9..bea8d4e3259dcb519d9c55d7f089cf1784f2a92e 100644
--- a/chrome/browser/android/download/download_controller.h
+++ b/chrome/browser/android/download/download_controller.h
@@ -33,9 +33,6 @@ class DownloadController : public DownloadControllerBase {
static bool RegisterDownloadController(JNIEnv* env);
- // Called when DownloadController Java object is instantiated.
- void Init(JNIEnv* env, jobject obj);
-
// DownloadControllerBase implementation.
void AcquireFileAccessPermission(
const content::ResourceRequestInfo::WebContentsGetter& wc_getter,
@@ -67,7 +64,6 @@ class DownloadController : public DownloadControllerBase {
AcquirePermissionCallback;
private:
- struct JavaObject;
friend struct base::DefaultSingletonTraits<DownloadController>;
DownloadController();
~DownloadController() override;
@@ -99,11 +95,6 @@ class DownloadController : public DownloadControllerBase {
const content::ResourceRequestInfo::WebContentsGetter& wc_getter,
const DownloadInfo& info, bool allowed);
- // Creates Java object if it is not created already and returns it.
- JavaObject* GetJavaObject();
-
- JavaObject* java_object_;
-
std::string default_file_name_;
DISALLOW_COPY_AND_ASSIGN(DownloadController);

Powered by Google App Engine
This is Rietveld 408576698