[DMC #17.5] Eliminate DocumentMarker and TextMatchMarker copy constructors

Eliminate DocumentMarker and TextMatchMarker copy constructors

We decided DocumentMarkers shouldn't ever be copied. After
https://codereview.chromium.org/2905753002, we no longer need to copy
DocumentMarkers to create TextMatchMarkers, so we can remove the copy
constructor. We can also remove the TextMatchMarker constructor that takes a
DocumentMarker.

We need to remove the copy constructor anyway because we're turning
DocumentMarker into a polymorphic class hierarchy, and copying the base class
will no longer produce correct behavior.

BUG=707867
Review-Url: https://codereview.chromium.org/2902393003
Cr-Commit-Position: refs/heads/master@{#475824}
Committed: https://chromium.googlesource.com/chromium/src/+/fa78f83615f6278ffe657bb6119d1b8339920b36

[rlanday, 2017-05-26 00:41:41]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[yosin_UTC9, 2017-05-26 04:41:30]

https://codereview.chromium.org/2902393003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarker.h (left):

https://codereview.chromium.org/2902393003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarker.h:145:
DocumentMarker(const DocumentMarker&);
Let's add DISALLOW_COPY_AND_ASSIGN(...)

[rlanday, 2017-05-26 18:28:00]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-26 18:28:03]

On 2017/05/26 at 04:41:30, yosin wrote:
>
https://codereview.chromium.org/2902393003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/markers/DocumentMarker.h (left):
> 
>
https://codereview.chromium.org/2902393003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/markers/DocumentMarker.h:145:
DocumentMarker(const DocumentMarker&);
> Let's add DISALLOW_COPY_AND_ASSIGN(...)

Updated

[commit-bot: I haz the power, 2017-05-26 18:28:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 18:32:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 18:32:58]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rlanday, 2017-05-26 21:39:37]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 21:40:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 00:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 00:59:33]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-28 19:41:16]

lgtm

[yosin_UTC9, 2017-05-29 04:58:48]

lgtm

[rlanday, 2017-05-31 04:30:23]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-05-31 04:30:23]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2902393003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-31 04:30:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 06:13:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496205023534930,
"parent_rev": "1ba49286da88e6351877f9b897530995db6c75bf", "commit_rev":
"fa78f83615f6278ffe657bb6119d1b8339920b36"}

[commit-bot: I haz the power, 2017-05-31 06:13:44]

Description was changed from

==========
Eliminate DocumentMarker and TextMatchMarker copy constructors

We decided DocumentMarkers shouldn't ever be copied. After
https://codereview.chromium.org/2905753002, we no longer need to copy
DocumentMarkers to create TextMatchMarkers, so we can remove the copy
constructor. We can also remove the TextMatchMarker constructor that takes a
DocumentMarker.

We need to remove the copy constructor anyway because we're turning
DocumentMarker into a polymorphic class hierarchy, and copying the base class
will no longer produce correct behavior.

BUG=707867
==========

to

==========
Eliminate DocumentMarker and TextMatchMarker copy constructors

We decided DocumentMarkers shouldn't ever be copied. After
https://codereview.chromium.org/2905753002, we no longer need to copy
DocumentMarkers to create TextMatchMarkers, so we can remove the copy
constructor. We can also remove the TextMatchMarker constructor that takes a
DocumentMarker.

We need to remove the copy constructor anyway because we're turning
DocumentMarker into a polymorphic class hierarchy, and copying the base class
will no longer produce correct behavior.

BUG=707867

Review-Url: https://codereview.chromium.org/2902393003
Cr-Commit-Position: refs/heads/master@{#475824}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa78f83615f6278ffe657bb6119d...
==========

[commit-bot: I haz the power, 2017-05-31 06:13:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fa78f83615f6278ffe657bb6119d...