third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp - Issue 2902393003: [DMC #17.5] Eliminate DocumentMarker and TextMatchMarker copy constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

Issue 2902393003: [DMC #17.5] Eliminate DocumentMarker and TextMatchMarker copy constructors (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp ('k') | third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

index c37a4fe5f9825b993ba9d57b71e637acf6a7325a..b629b20b3212183d45bdf9cba90c1df3961766e7 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

@@ -66,7 +66,7 @@ bool DocumentMarkerListEditor::RemoveMarkers(MarkerList* list,

return start_offset < marker->EndOffset();

});

for (MarkerList::iterator i = start_pos; i != list->end();) {

- DocumentMarker marker(*i->Get());

+ const DocumentMarker& marker = *i->Get();

// markers are returned in order, so stop if we are now past the specified

// range