Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2901933002:
[CUPS] Re-enable the button to switch to auto-discovery dialog. (Closed)
|
Created:
3 years, 7 months ago by xdai1 Modified:
3 years, 6 months ago Reviewers:
michaelpg CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[CUPS] Re-enable the button to switch to auto-discovery dialog.
Re-enable the button to switch from the manual-add-printer dialog to
auto-discovery dialog. The button was removed in M59. We need to re-enable
this butten as we add in USB and Auto-Discovery setup workflows in M60.
BUG=725557
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2901933002
Cr-Commit-Position: refs/heads/master@{#475207}
Committed: https://chromium.googlesource.com/chromium/src/+/002a1fcdbdd3244720d12c2f7b1593c6f0ab8544
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== [CUPS] Re-enable the button to switch to auto-discovery dialog. Re-enable the button to switch from the manual-add-printer dialog to auto-discovery dialog. We need to re-enable this butten as we add in USB and Auto-Discovery setup workflows in M60. BUG=725557 ========== to ========== [CUPS] Re-enable the button to switch to auto-discovery dialog. Re-enable the button to switch from the manual-add-printer dialog to auto-discovery dialog. We need to re-enable this butten as we add in USB and Auto-Discovery setup workflows in M60. BUG=725557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [CUPS] Re-enable the button to switch to auto-discovery dialog. Re-enable the button to switch from the manual-add-printer dialog to auto-discovery dialog. We need to re-enable this butten as we add in USB and Auto-Discovery setup workflows in M60. BUG=725557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [CUPS] Re-enable the button to switch to auto-discovery dialog. Re-enable the button to switch from the manual-add-printer dialog to auto-discovery dialog. The button was removed in M59. We need to re-enable this butten as we add in USB and Auto-Discovery setup workflows in M60. BUG=725557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by xdai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
xdai@chromium.org changed reviewers: + michaelpg@chromium.org
michaelpg@, could you help review this CL please? Thanks!
can this be landed as a revert?
On 2017/05/24 21:38:52, michaelpg wrote: > can this be landed as a revert? There is no a clean CL to revert. The button was removed in this CL https://codereview.chromium.org/2489953004 by skau@. However, the code was modified several times in the middle so reverting the original doesn't make sense any more.
lgtm
The CQ bit was checked by xdai@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495839968475970, "parent_rev":
"f2e1cb01c032ad6090f25ba12b38eb8badc1626f", "commit_rev":
"bda040281870c1881d5a2d01083ec5c80d90a550"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495839968475970, "parent_rev":
"839915a80523ace89c210acff0ffc429e73fa014", "commit_rev":
"c4c25d395e5b88f3d6c94847c3dec610b53dfc35"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495839968475970, "parent_rev":
"76a9686cec40a666328e9af2238f6cfabb02ed30", "commit_rev":
"002a1fcdbdd3244720d12c2f7b1593c6f0ab8544"}
Message was sent while issue was closed.
Description was changed from ========== [CUPS] Re-enable the button to switch to auto-discovery dialog. Re-enable the button to switch from the manual-add-printer dialog to auto-discovery dialog. The button was removed in M59. We need to re-enable this butten as we add in USB and Auto-Discovery setup workflows in M60. BUG=725557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [CUPS] Re-enable the button to switch to auto-discovery dialog. Re-enable the button to switch from the manual-add-printer dialog to auto-discovery dialog. The button was removed in M59. We need to re-enable this butten as we add in USB and Auto-Discovery setup workflows in M60. BUG=725557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2901933002 Cr-Commit-Position: refs/heads/master@{#475207} Committed: https://chromium.googlesource.com/chromium/src/+/002a1fcdbdd3244720d12c2f7b15... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/002a1fcdbdd3244720d12c2f7b15... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
