Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2489953004: Remove Nearby printer UI from settings. (Closed)

Created:
4 years, 1 month ago by skau
Modified:
4 years, 1 month ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, xdai1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Nearby printer UI from settings. Nearby printer detection isn't implemented yet so the UI needs to be pulled temporarily. BUG=663597 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/76ae8386102f59d2c5a6fb935b6e408ecba1a078 Cr-Commit-Position: refs/heads/master@{#431394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
skau
hcarmona@: Could you take a look? xdai@ is OOO.
4 years, 1 month ago (2016-11-10 19:30:44 UTC) #3
hcarmona
lgtm
4 years, 1 month ago (2016-11-10 20:03:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489953004/1
4 years, 1 month ago (2016-11-10 20:40:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 23:18:28 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 23:28:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76ae8386102f59d2c5a6fb935b6e408ecba1a078
Cr-Commit-Position: refs/heads/master@{#431394}

Powered by Google App Engine
This is Rietveld 408576698