Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2901893002: Re-land: Refactor Select-to-speak so that mouse events are forwarded to the extension. (Closed)

Created:
3 years, 7 months ago by dmazzoni
Modified:
3 years, 7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, je_julie, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Refactor Select-to-speak so that mouse events are forwarded to the extension. Originally landed: r472339 (https://codereview.chromium.org/2814213002) Reverted: r472397 (https://codereview.chromium.org/2883283003) Previously the Select-to-speak event handler captured mouse events and turned them into accessibility events that could be caught by select-to-speak. Instead, the event handler can mouse and keyboard events to the extension background page, and the extension can use the automation API to do a hit test. This is mostly a refactoring change, but it gives us some more flexibility and makes the event handler simpler, possibly something that could be general-purpose, while putting more of the logic into the extension code. BUG=699617 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=dtseng Review-Url: https://codereview.chromium.org/2901893002 Cr-Commit-Position: refs/heads/master@{#474026} Committed: https://chromium.googlesource.com/chromium/src/+/8dadb18e68fa9688acfcd10757fade7ca980c0d7

Patch Set 1 #

Patch Set 2 : Fix uninitialized pointer #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -171 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler.h View 1 3 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc View 6 chunks +59 lines, -63 lines 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc View 11 chunks +33 lines, -65 lines 0 comments Download
M chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js View 5 chunks +147 lines, -36 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901893002/40001
3 years, 7 months ago (2017-05-23 18:15:39 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 20:15:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8dadb18e68fa9688acfcd10757fa...

Powered by Google App Engine
This is Rietveld 408576698