Chromium Code Reviews
DescriptionRe-land: Refactor Select-to-speak so that mouse events are forwarded to the extension.
Originally landed: r472339 (https://codereview.chromium.org/2814213002)
Reverted: r472397 (https://codereview.chromium.org/2883283003)
Previously the Select-to-speak event handler captured mouse events and
turned them into accessibility events that could be caught by
select-to-speak.
Instead, the event handler can mouse and keyboard events to the extension
background page, and the extension can use the automation API to do a hit test.
This is mostly a refactoring change, but it gives us some more flexibility
and makes the event handler simpler, possibly something that could be
general-purpose, while putting more of the logic into the extension code.
BUG=699617
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dtseng
Review-Url: https://codereview.chromium.org/2901893002
Cr-Commit-Position: refs/heads/master@{#474026}
Committed: https://chromium.googlesource.com/chromium/src/+/8dadb18e68fa9688acfcd10757fade7ca980c0d7
Patch Set 1 #Patch Set 2 : Fix uninitialized pointer #Patch Set 3 : Rebase #
Messages
Total messages: 11 (9 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||