DescriptionRevert of Refactor Select-to-speak so that mouse events are forwarded to the extension. (patchset #7 id:120001 of https://codereview.chromium.org/2814213002/ )
Reason for revert:
FindIt detected this CL as culprit for test failures.
https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/26122
Original issue's description:
> Refactor Select-to-speak so that mouse events are forwarded to the extension.
>
> Previously the Select-to-speak event handler captured mouse events and
> turned them into accessibility events that could be caught by
> select-to-speak.
>
> Instead, the event handler can mouse and keyboard events to the extension
> background page, and the extension can use the automation API to do a hit test.
>
> This is mostly a refactoring change, but it gives us some more flexibility
> and makes the event handler simpler, possibly something that could be
> general-purpose, while putting more of the logic into the extension code.
>
> BUG=699617
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2814213002
> Cr-Commit-Position: refs/heads/master@{#472339}
> Committed: https://chromium.googlesource.com/chromium/src/+/ccb40f537fbbc17772e7255a7b575661ce4353cd
TBR=dtseng@chromium.org,dmazzoni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699617
Review-Url: https://codereview.chromium.org/2883283003
Cr-Commit-Position: refs/heads/master@{#472397}
Committed: https://chromium.googlesource.com/chromium/src/+/3baeba114a6669b0a2c02842cfa10bb293e5c57e
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|