Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2883283003: Revert of Refactor Select-to-speak so that mouse events are forwarded to the extension. (Closed)

Created:
3 years, 7 months ago by kolos1
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, jam, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, dtapuska+chromiumwatch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org, dtapuska
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor Select-to-speak so that mouse events are forwarded to the extension. (patchset #7 id:120001 of https://codereview.chromium.org/2814213002/ ) Reason for revert: FindIt detected this CL as culprit for test failures. https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/26122 Original issue's description: > Refactor Select-to-speak so that mouse events are forwarded to the extension. > > Previously the Select-to-speak event handler captured mouse events and > turned them into accessibility events that could be caught by > select-to-speak. > > Instead, the event handler can mouse and keyboard events to the extension > background page, and the extension can use the automation API to do a hit test. > > This is mostly a refactoring change, but it gives us some more flexibility > and makes the event handler simpler, possibly something that could be > general-purpose, while putting more of the logic into the extension code. > > BUG=699617 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2814213002 > Cr-Commit-Position: refs/heads/master@{#472339} > Committed: https://chromium.googlesource.com/chromium/src/+/ccb40f537fbbc17772e7255a7b575661ce4353cd TBR=dtseng@chromium.org,dmazzoni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699617 Review-Url: https://codereview.chromium.org/2883283003 Cr-Commit-Position: refs/heads/master@{#472397} Committed: https://chromium.googlesource.com/chromium/src/+/3baeba114a6669b0a2c02842cfa10bb293e5c57e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -287 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler.h View 3 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc View 6 chunks +63 lines, -59 lines 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc View 9 chunks +96 lines, -64 lines 0 comments Download
M chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js View 6 chunks +40 lines, -151 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kolos1
Created Revert of Refactor Select-to-speak so that mouse events are forwarded to the extension.
3 years, 7 months ago (2017-05-17 09:32:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883283003/1
3 years, 7 months ago (2017-05-17 09:33:03 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 09:33:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3baeba114a6669b0a2c02842cfa1...

Powered by Google App Engine
This is Rietveld 408576698