Record histogram of reason for quads not being put in an overlay.

Record histogram of reason for quads not being put in an overlay.

This will help determine if there are any properties we can handle to
increase the number of pages that use overlays.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2901723002
Cr-Commit-Position: refs/heads/master@{#474565}
Committed: https://chromium.googlesource.com/chromium/src/+/a173de904dfe728ce1e5ef3fa9736874a37e8553

[jbauman, 2017-05-23 02:37:24]

Description was changed from

==========
Record histogram of reason for quads not being put in an overlay.

This will help determine if there are any properties we can handle to
increase the number of pages that use overlays.
==========

to

==========
Record histogram of reason for quads not being put in an overlay.

This will help determine if there are any properties we can handle to
increase the number of pages that use overlays.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jbauman, 2017-05-23 02:37:31]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 02:37:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 03:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 03:47:34]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-05-23 22:12:53]

jbauman@chromium.org changed reviewers:
+ ccameron@chromium.org

[ccameron, 2017-05-24 23:41:56]

lgtm (though historically I always make mistakes in my histograms.xmls)

[jbauman, 2017-05-24 23:46:13]

jbauman@chromium.org changed reviewers:
+ isherman@chromium.org

[jbauman, 2017-05-24 23:46:14]

isherman@: histograms.xml review.

[Ilya Sherman, 2017-05-24 23:52:49]

LGTM % a nit:

https://codereview.chromium.org/2901723002/diff/1/cc/output/dc_layer_overlay.cc
File cc/output/dc_layer_overlay.cc (right):

https://codereview.chromium.org/2901723002/diff/1/cc/output/dc_layer_overlay....
cc/output/dc_layer_overlay.cc:144: DC_LAYER_FAILED_MAX);
nit: The UMA_HISTOGRAM macros expand to a fair bit of code, so to help the
compiler avoid duplicating it, I'd recommend extracting out a small wrapper
function that you'd call like so:

  RecordDCLayerResult(DC_LAYER_FAILED_COMPLEX_TRANSFORM);

[jbauman, 2017-05-25 00:15:32]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2017-05-25 00:15:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2901723002/#ps20001
(title: "put in one function")

[commit-bot: I haz the power, 2017-05-25 00:16:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 01:48:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 01:49:00]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jbauman, 2017-05-25 01:53:51]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2017-05-25 01:55:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 05:30:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495677231631580,
"parent_rev": "9da3c7fa4bd8295789a5900732f9091524fe07c1", "commit_rev":
"a173de904dfe728ce1e5ef3fa9736874a37e8553"}

[commit-bot: I haz the power, 2017-05-25 05:30:56]

Description was changed from

==========
Record histogram of reason for quads not being put in an overlay.

This will help determine if there are any properties we can handle to
increase the number of pages that use overlays.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Record histogram of reason for quads not being put in an overlay.

This will help determine if there are any properties we can handle to
increase the number of pages that use overlays.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2901723002
Cr-Commit-Position: refs/heads/master@{#474565}
Committed:
https://chromium.googlesource.com/chromium/src/+/a173de904dfe728ce1e5ef3fa973...
==========

[commit-bot: I haz the power, 2017-05-25 05:30:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a173de904dfe728ce1e5ef3fa973...