Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: cc/output/dc_layer_overlay.cc

Issue 2901723002: Record histogram of reason for quads not being put in an overlay. (Closed)
Patch Set: put in one function Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/output/dc_layer_overlay.h ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/dc_layer_overlay.h" 5 #include "cc/output/dc_layer_overlay.h"
6 6
7 #include "base/metrics/histogram_macros.h"
7 #include "cc/base/math_util.h" 8 #include "cc/base/math_util.h"
8 #include "cc/quads/solid_color_draw_quad.h" 9 #include "cc/quads/solid_color_draw_quad.h"
9 #include "cc/quads/yuv_video_draw_quad.h" 10 #include "cc/quads/yuv_video_draw_quad.h"
10 #include "cc/resources/resource_provider.h" 11 #include "cc/resources/resource_provider.h"
11 #include "gpu/GLES2/gl2extchromium.h" 12 #include "gpu/GLES2/gl2extchromium.h"
12 #include "ui/gfx/geometry/rect_conversions.h" 13 #include "ui/gfx/geometry/rect_conversions.h"
13 #include "ui/gl/gl_switches.h" 14 #include "ui/gl/gl_switches.h"
14 15
15 namespace cc { 16 namespace cc {
16 17
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 continue; 62 continue;
62 } 63 }
63 overlap_rect.Intersect(target_quad); 64 overlap_rect.Intersect(target_quad);
64 if (!overlap_rect.IsEmpty()) { 65 if (!overlap_rect.IsEmpty()) {
65 occlusion_bounding_box.Union(overlap_rect); 66 occlusion_bounding_box.Union(overlap_rect);
66 } 67 }
67 } 68 }
68 return occlusion_bounding_box; 69 return occlusion_bounding_box;
69 } 70 }
70 71
72 void RecordDCLayerResult(DCLayerOverlayProcessor::DCLayerResult result) {
73 UMA_HISTOGRAM_ENUMERATION("GPU.DirectComposition.DCLayerResult", result,
74 DCLayerOverlayProcessor::DC_LAYER_FAILED_MAX);
75 }
76
71 } // namespace 77 } // namespace
72 78
73 DCLayerOverlay::DCLayerOverlay() : filter(GL_LINEAR) {} 79 DCLayerOverlay::DCLayerOverlay() : filter(GL_LINEAR) {}
74 80
75 DCLayerOverlay::DCLayerOverlay(const DCLayerOverlay& other) = default; 81 DCLayerOverlay::DCLayerOverlay(const DCLayerOverlay& other) = default;
76 82
77 DCLayerOverlay::~DCLayerOverlay() {} 83 DCLayerOverlay::~DCLayerOverlay() {}
78 84
79 DCLayerOverlayProcessor::DCLayerResult DCLayerOverlayProcessor::FromDrawQuad( 85 DCLayerOverlayProcessor::DCLayerResult DCLayerOverlayProcessor::FromDrawQuad(
80 ResourceProvider* resource_provider, 86 ResourceProvider* resource_provider,
81 const gfx::RectF& display_rect, 87 const gfx::RectF& display_rect,
82 QuadList::ConstIterator quad_list_begin, 88 QuadList::ConstIterator quad_list_begin,
83 QuadList::ConstIterator quad, 89 QuadList::ConstIterator quad,
84 DCLayerOverlay* ca_layer_overlay) { 90 DCLayerOverlay* ca_layer_overlay) {
85 if (quad->shared_quad_state->blend_mode != SkBlendMode::kSrcOver) 91 if (quad->shared_quad_state->blend_mode != SkBlendMode::kSrcOver)
86 return DC_LAYER_FAILED_QUAD_BLEND_MODE; 92 return DC_LAYER_FAILED_QUAD_BLEND_MODE;
87 93
88 DCLayerResult result = DC_LAYER_FAILED_UNKNOWN; 94 DCLayerResult result;
89 switch (quad->material) { 95 switch (quad->material) {
90 case DrawQuad::YUV_VIDEO_CONTENT: 96 case DrawQuad::YUV_VIDEO_CONTENT:
91 result = 97 result =
92 FromYUVQuad(resource_provider, YUVVideoDrawQuad::MaterialCast(*quad), 98 FromYUVQuad(resource_provider, YUVVideoDrawQuad::MaterialCast(*quad),
93 ca_layer_overlay); 99 ca_layer_overlay);
94 break; 100 break;
95 default: 101 default:
96 return DC_LAYER_FAILED_UNKNOWN; 102 return DC_LAYER_FAILED_UNSUPPORTED_QUAD;
97 } 103 }
98 if (result != DC_LAYER_SUCCESS) 104 if (result != DC_LAYER_SUCCESS)
99 return result; 105 return result;
100 106
101 scoped_refptr<DCLayerOverlaySharedState> overlay_shared_state( 107 scoped_refptr<DCLayerOverlaySharedState> overlay_shared_state(
102 new DCLayerOverlaySharedState); 108 new DCLayerOverlaySharedState);
103 overlay_shared_state->z_order = 1; 109 overlay_shared_state->z_order = 1;
104 110
105 overlay_shared_state->is_clipped = quad->shared_quad_state->is_clipped; 111 overlay_shared_state->is_clipped = quad->shared_quad_state->is_clipped;
106 overlay_shared_state->clip_rect = 112 overlay_shared_state->clip_rect =
(...skipping 14 matching lines...) Expand all
121 QuadList* quad_list, 127 QuadList* quad_list,
122 gfx::Rect* overlay_damage_rect, 128 gfx::Rect* overlay_damage_rect,
123 gfx::Rect* damage_rect, 129 gfx::Rect* damage_rect,
124 DCLayerOverlayList* ca_layer_overlays) { 130 DCLayerOverlayList* ca_layer_overlays) {
125 gfx::Rect this_frame_underlay_rect; 131 gfx::Rect this_frame_underlay_rect;
126 bool display_rect_changed = (display_rect != previous_display_rect_); 132 bool display_rect_changed = (display_rect != previous_display_rect_);
127 for (auto it = quad_list->begin(); it != quad_list->end(); ++it) { 133 for (auto it = quad_list->begin(); it != quad_list->end(); ++it) {
128 DCLayerOverlay ca_layer; 134 DCLayerOverlay ca_layer;
129 DCLayerResult result = FromDrawQuad(resource_provider, display_rect, 135 DCLayerResult result = FromDrawQuad(resource_provider, display_rect,
130 quad_list->begin(), it, &ca_layer); 136 quad_list->begin(), it, &ca_layer);
131 if (result != DC_LAYER_SUCCESS) 137 if (result != DC_LAYER_SUCCESS) {
138 RecordDCLayerResult(result);
132 continue; 139 continue;
140 }
133 141
134 if (!it->shared_quad_state->quad_to_target_transform 142 if (!it->shared_quad_state->quad_to_target_transform
135 .Preserves2dAxisAlignment() && 143 .Preserves2dAxisAlignment() &&
136 !base::FeatureList::IsEnabled( 144 !base::FeatureList::IsEnabled(
137 features::kDirectCompositionComplexOverlays)) { 145 features::kDirectCompositionComplexOverlays)) {
146 RecordDCLayerResult(DC_LAYER_FAILED_COMPLEX_TRANSFORM);
138 continue; 147 continue;
139 } 148 }
140 149
141 gfx::Rect quad_rectangle = gfx::ToEnclosingRect(ClippedQuadRectangle(*it)); 150 gfx::Rect quad_rectangle = gfx::ToEnclosingRect(ClippedQuadRectangle(*it));
142 gfx::RectF occlusion_bounding_box = 151 gfx::RectF occlusion_bounding_box =
143 GetOcclusionBounds(gfx::RectF(quad_rectangle), quad_list->begin(), it); 152 GetOcclusionBounds(gfx::RectF(quad_rectangle), quad_list->begin(), it);
144 if (occlusion_bounding_box.IsEmpty()) { 153 if (occlusion_bounding_box.IsEmpty()) {
145 // The quad is on top, so promote it to an overlay and remove all damage 154 // The quad is on top, so promote it to an overlay and remove all damage
146 // underneath it. 155 // underneath it.
147 if (it->shared_quad_state->quad_to_target_transform 156 if (it->shared_quad_state->quad_to_target_transform
148 .Preserves2dAxisAlignment() && 157 .Preserves2dAxisAlignment() &&
149 !display_rect_changed && !it->ShouldDrawWithBlending()) { 158 !display_rect_changed && !it->ShouldDrawWithBlending()) {
150 damage_rect->Subtract(quad_rectangle); 159 damage_rect->Subtract(quad_rectangle);
151 } 160 }
152 quad_list->EraseAndInvalidateAllPointers(it); 161 quad_list->EraseAndInvalidateAllPointers(it);
153 } else if (!base::FeatureList::IsEnabled( 162 } else if (!base::FeatureList::IsEnabled(
154 features::kDirectCompositionUnderlays)) { 163 features::kDirectCompositionUnderlays)) {
164 RecordDCLayerResult(DC_LAYER_FAILED_OCCLUDED);
155 continue; 165 continue;
156 } else { 166 } else {
157 // The quad is occluded, so replace it with a black solid color quad and 167 // The quad is occluded, so replace it with a black solid color quad and
158 // place the overlay itself under the quad. 168 // place the overlay itself under the quad.
159 if (it->shared_quad_state->quad_to_target_transform 169 if (it->shared_quad_state->quad_to_target_transform
160 .IsIdentityOrIntegerTranslation()) { 170 .IsIdentityOrIntegerTranslation()) {
161 this_frame_underlay_rect = quad_rectangle; 171 this_frame_underlay_rect = quad_rectangle;
162 } 172 }
163 ca_layer.shared_state->z_order = -1; 173 ca_layer.shared_state->z_order = -1;
164 const SharedQuadState* shared_quad_state = it->shared_quad_state; 174 const SharedQuadState* shared_quad_state = it->shared_quad_state;
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 ca_layer_overlays->push_back(ca_layer); 208 ca_layer_overlays->push_back(ca_layer);
199 // Only allow one overlay for now. 209 // Only allow one overlay for now.
200 break; 210 break;
201 } 211 }
202 damage_rect->Intersect(gfx::ToEnclosingRect(display_rect)); 212 damage_rect->Intersect(gfx::ToEnclosingRect(display_rect));
203 previous_frame_underlay_rect_ = this_frame_underlay_rect; 213 previous_frame_underlay_rect_ = this_frame_underlay_rect;
204 previous_display_rect_ = display_rect; 214 previous_display_rect_ = display_rect;
205 } 215 }
206 216
207 } // namespace cc 217 } // namespace cc
OLDNEW
« no previous file with comments | « cc/output/dc_layer_overlay.h ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698