Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2901663002: [ios clean] Fixes Menu Overflow Controls UI (Closed)

Created:
3 years, 7 months ago by sczs
Modified:
3 years, 7 months ago
Reviewers:
edchin, lpromero
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -23 lines) Patch
M ios/clean/chrome/browser/ui/toolbar/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm View 2 chunks +14 lines, -1 line 0 comments Download
M ios/clean/chrome/browser/ui/tools/menu_view_controller.mm View 11 chunks +69 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
lpromero
lgtm
3 years, 7 months ago (2017-05-23 08:40:35 UTC) #5
lpromero
Please expand the abbreviation to "screenshot" in the description.
3 years, 7 months ago (2017-05-23 08:41:02 UTC) #6
sczs
On 2017/05/23 08:41:02, lpromero wrote: > Please expand the abbreviation to "screenshot" in the description. ...
3 years, 7 months ago (2017-05-23 15:39:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901663002/40001
3 years, 7 months ago (2017-05-23 15:41:03 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 16:56:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bd95b4b8ee9e4cf14ed3021a194d...

Powered by Google App Engine
This is Rietveld 408576698