Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3527)

Unified Diff: ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm

Issue 2901663002: [ios clean] Fixes Menu Overflow Controls UI (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm
diff --git a/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm b/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm
index d5c7f52804014e770c8e758a4a579bccdcd8fac8..55acb244b3d00af5cd5e91066d242773d3cfac0e 100644
--- a/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm
+++ b/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm
@@ -6,19 +6,29 @@
#import "ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+namespace {
+const CGFloat kStackSpacing = 15.0;
+}
+
@implementation MenuOverflowControlsStackView
@synthesize shareButton = _shareButton;
@synthesize reloadButton = _reloadButton;
@synthesize stopButton = _stopButton;
+@synthesize starButton = _starButton;
- (instancetype)init {
if ((self = [super init])) {
- // PLACEHOLDER: Buttons and UI config is not final and will be improved.
[self setUpToolbarButtons];
[self addArrangedSubview:self.shareButton];
+ [self addArrangedSubview:self.starButton];
[self addArrangedSubview:self.stopButton];
[self addArrangedSubview:self.reloadButton];
+ self.spacing = kStackSpacing;
self.axis = UILayoutConstraintAxisHorizontal;
self.distribution = UIStackViewDistributionFillEqually;
}
@@ -36,6 +46,9 @@
// Stop button.
self.stopButton = [ToolbarButton stopToolbarButton];
+
+ // Star button.
+ self.starButton = [ToolbarButton starToolbarButton];
}
@end

Powered by Google App Engine
This is Rietveld 408576698