Fold AppModalDialog into its only subclass, JavaScriptAppModalDialog.

Fold AppModalDialog into its only subclass, JavaScriptAppModalDialog.

There once was a second subclass, CookiePromptModalDialog, but it was removed in r59838, more than 6 years ago.

BUG=725111
Review-Url: https://codereview.chromium.org/2901583002
Cr-Commit-Position: refs/heads/master@{#475108}
Committed: https://chromium.googlesource.com/chromium/src/+/373e72a7db96f15fa0adb679efb9992078500251

[Avi (use Gerrit), 2017-05-22 18:56:59]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:57:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 19:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 19:15:59]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Avi (use Gerrit), 2017-05-22 19:30:23]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 19:31:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 20:07:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:07:35]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2017-05-23 00:34:06]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 00:34:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 01:37:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 01:37:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2017-05-24 19:48:50]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 19:49:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 20:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 20:36:59]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Avi (use Gerrit), 2017-05-26 19:03:34]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 19:04:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 20:23:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 20:23:05]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-05-26 20:23:53]

avi@chromium.org changed reviewers:
+ thakis@chromium.org

[Avi (use Gerrit), 2017-05-26 20:23:53]

Nico, ptal

[Nico, 2017-05-26 20:25:55]

lgtm

[Avi (use Gerrit), 2017-05-26 20:27:39]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-05-26 20:28:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 20:33:55]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495830459952090,
"parent_rev": "a11be0d57a4e4f214588bbd6fab9398824802b7f", "commit_rev":
"373e72a7db96f15fa0adb679efb9992078500251"}

[commit-bot: I haz the power, 2017-05-26 20:34:07]

Description was changed from

==========
Fold AppModalDialog into its only subclass, JavaScriptAppModalDialog.

There once was a second subclass, CookiePromptModalDialog, but it was removed in
r59838, more than 6 years ago.

BUG=725111
==========

to

==========
Fold AppModalDialog into its only subclass, JavaScriptAppModalDialog.

There once was a second subclass, CookiePromptModalDialog, but it was removed in
r59838, more than 6 years ago.

BUG=725111

Review-Url: https://codereview.chromium.org/2901583002
Cr-Commit-Position: refs/heads/master@{#475108}
Committed:
https://chromium.googlesource.com/chromium/src/+/373e72a7db96f15fa0adb679efb9...
==========

[commit-bot: I haz the power, 2017-05-26 20:34:08]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/373e72a7db96f15fa0adb679efb9...