chrome/browser/ui/android/javascript_app_modal_dialog_android.cc - Issue 2901583002: Fold AppModalDialog into its only subclass, JavaScriptAppModalDialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

Issue 2901583002: Fold AppModalDialog into its only subclass, JavaScriptAppModalDialog. (Closed)

Patch Set: fix collapse Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

diff --git a/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc b/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

index fe7062cec08057892d024547a352903fe14ba6cb..f3aeb721979af5da45b1949e48c0eb2cd5718922 100644

--- a/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

+++ b/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

@@ -152,7 +152,7 @@ const ScopedJavaGlobalRef<jobject>&

ScopedJavaLocalRef<jobject> GetCurrentModalDialog(

JNIEnv* env,

const JavaParamRef<jclass>& clazz) {

- app_modal::AppModalDialog* dialog =

+ app_modal::JavaScriptAppModalDialog* dialog =

app_modal::AppModalDialogQueue::GetInstance()->active_dialog();

if (!dialog || !dialog->native_dialog())

return ScopedJavaLocalRef<jobject>();