Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2901383006: Replace URLRequestContextBuilder::HttpNetworkSessionParams (Closed)

Created:
3 years, 7 months ago by mmenke
Modified:
3 years, 6 months ago
CC:
chromium-reviews, asanka, cbentzel+watch_chromium.org, jam, Randy Smith (Not in Mondays), net-reviews_chromium.org, kinuko, darin-cc_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace URLRequestContextBuilder::HttpNetworkSessionParams with HttpNetworkSession::Params. The former was a subset of the latter. This allows almost any configuration option to be applied to an HttpNetworkSession created by a URLRequestContextBuilder. TBR=tobiasjs@chromium.org BUG=715695 Review-Url: https://codereview.chromium.org/2901383006 Cr-Commit-Position: refs/heads/master@{#476109} Committed: https://chromium.googlesource.com/chromium/src/+/7c7f4faf577a95b53693641cae1b60348d26c359

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Merge.... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -82 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/network/network_context.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/url_request/url_request_context_builder.h View 4 chunks +2 lines, -30 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 3 chunks +1 line, -48 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 30 (21 generated)
mmenke
Almost ready to switch IOThread over to URLRequestContextBuilder, I believe, at long last!
3 years, 7 months ago (2017-05-26 18:04:34 UTC) #4
Randy Smith (Not in Mondays)
In the CL description, can you change the second instance of the string "HttpNetworkSessionParams" to ...
3 years, 6 months ago (2017-05-31 19:04:28 UTC) #15
mmenke
On 2017/05/31 19:04:28, Randy Smith (Not in Mondays) wrote: > In the CL description, can ...
3 years, 6 months ago (2017-05-31 19:10:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901383006/40001
3 years, 6 months ago (2017-05-31 21:54:46 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/452522)
3 years, 6 months ago (2017-05-31 22:05:48 UTC) #21
mmenke
[+tobiasjs]: TBRing you for android_webview/browser/net/aw_url_request_context_getter.cc. I'm basically replacing one POD class with another one that ...
3 years, 6 months ago (2017-05-31 22:51:26 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901383006/40001
3 years, 6 months ago (2017-05-31 22:52:07 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/7c7f4faf577a95b53693641cae1b60348d26c359
3 years, 6 months ago (2017-06-01 00:25:37 UTC) #29
Tobias Sargeant
3 years, 6 months ago (2017-06-01 08:28:58 UTC) #30
Message was sent while issue was closed.
ex post facto LGTM

Powered by Google App Engine
This is Rietveld 408576698