chrome/renderer/page_load_metrics/metrics_render_frame_observer.h - Issue 2901383002: Buffer cross frame paint timing updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2901383002: Buffer cross frame paint timing updates. (Closed)

Patch Set: address comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

index 78b8b3f962e21a2aada2511822fc5ec75daed960..db52f07effc6eaa50ddb1f8501d37140753595d9 100644

--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

@@ -47,7 +47,7 @@ class MetricsRenderFrameObserver : public content::RenderFrameObserver {

void SendMetrics();

virtual bool ShouldSendMetrics() const;

virtual mojom::PageLoadTimingPtr GetTiming() const;

- virtual std::unique_ptr<base::Timer> CreateTimer() const;

+ virtual std::unique_ptr<base::Timer> CreateTimer();

virtual std::unique_ptr<PageTimingSender> CreatePageTimingSender();

virtual bool HasNoRenderFrame() const;