chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc - Issue 2901383002: Buffer cross frame paint timing updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Issue 2901383002: Buffer cross frame paint timing updates. (Closed)

Patch Set: address comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

index 9996789b18d90ae56532d9efe4f100b0b9e16bd4..64352d0601a3fe0809ba606fd7e86bc9506d9aff 100644

--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

@@ -207,8 +207,8 @@ mojom::PageLoadTimingPtr MetricsRenderFrameObserver::GetTiming() const {

return timing;

}

-std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const {

- return base::WrapUnique(new base::OneShotTimer);

+std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() {

+ return base::MakeUnique<base::OneShotTimer>();

}

std::unique_ptr<PageTimingSender>