Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2901383002: Buffer cross frame paint timing updates. (Closed)
Patch Set: address comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 29 matching lines...) Expand all
40 void OnDestruct() override; 40 void OnDestruct() override;
41 41
42 // Invoked when a frame is going away. This is our last chance to send IPCs 42 // Invoked when a frame is going away. This is our last chance to send IPCs
43 // before being destroyed. 43 // before being destroyed.
44 void FrameDetached() override; 44 void FrameDetached() override;
45 45
46 private: 46 private:
47 void SendMetrics(); 47 void SendMetrics();
48 virtual bool ShouldSendMetrics() const; 48 virtual bool ShouldSendMetrics() const;
49 virtual mojom::PageLoadTimingPtr GetTiming() const; 49 virtual mojom::PageLoadTimingPtr GetTiming() const;
50 virtual std::unique_ptr<base::Timer> CreateTimer() const; 50 virtual std::unique_ptr<base::Timer> CreateTimer();
51 virtual std::unique_ptr<PageTimingSender> CreatePageTimingSender(); 51 virtual std::unique_ptr<PageTimingSender> CreatePageTimingSender();
52 virtual bool HasNoRenderFrame() const; 52 virtual bool HasNoRenderFrame() const;
53 53
54 // Will be null when we're not actively sending metrics. 54 // Will be null when we're not actively sending metrics.
55 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_; 55 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
56 56
57 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver); 57 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);
58 }; 58 };
59 59
60 } // namespace page_load_metrics 60 } // namespace page_load_metrics
61 61
62 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 62 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698