Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Issue 2901383002: Buffer cross frame paint timing updates. (Closed)
Patch Set: address comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h" 5 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/feature_list.h" 9 #include "base/feature_list.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 base::TimeDelta::FromSecondsD( 200 base::TimeDelta::FromSecondsD(
201 perf.AuthorStyleSheetParseDurationBeforeFCP()); 201 perf.AuthorStyleSheetParseDurationBeforeFCP());
202 } 202 }
203 if (perf.UpdateStyleDurationBeforeFCP() > 0.0) { 203 if (perf.UpdateStyleDurationBeforeFCP() > 0.0) {
204 timing->style_sheet_timing->update_style_duration_before_fcp = 204 timing->style_sheet_timing->update_style_duration_before_fcp =
205 base::TimeDelta::FromSecondsD(perf.UpdateStyleDurationBeforeFCP()); 205 base::TimeDelta::FromSecondsD(perf.UpdateStyleDurationBeforeFCP());
206 } 206 }
207 return timing; 207 return timing;
208 } 208 }
209 209
210 std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const { 210 std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() {
211 return base::WrapUnique(new base::OneShotTimer); 211 return base::MakeUnique<base::OneShotTimer>();
212 } 212 }
213 213
214 std::unique_ptr<PageTimingSender> 214 std::unique_ptr<PageTimingSender>
215 MetricsRenderFrameObserver::CreatePageTimingSender() { 215 MetricsRenderFrameObserver::CreatePageTimingSender() {
216 if (base::FeatureList::IsEnabled(features::kPageLoadMetricsMojofication)) { 216 if (base::FeatureList::IsEnabled(features::kPageLoadMetricsMojofication)) {
217 return base::WrapUnique<PageTimingSender>( 217 return base::WrapUnique<PageTimingSender>(
218 new MojoIPCPageTimingSender(render_frame())); 218 new MojoIPCPageTimingSender(render_frame()));
219 } 219 }
220 return base::WrapUnique<PageTimingSender>( 220 return base::WrapUnique<PageTimingSender>(
221 new LegacyIPCPageTimingSender(render_frame(), routing_id())); 221 new LegacyIPCPageTimingSender(render_frame(), routing_id()));
222 } 222 }
223 223
224 bool MetricsRenderFrameObserver::HasNoRenderFrame() const { 224 bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
225 bool no_frame = !render_frame() || !render_frame()->GetWebFrame(); 225 bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
226 DCHECK(!no_frame); 226 DCHECK(!no_frame);
227 return no_frame; 227 return no_frame;
228 } 228 }
229 229
230 void MetricsRenderFrameObserver::OnDestruct() { 230 void MetricsRenderFrameObserver::OnDestruct() {
231 delete this; 231 delete this;
232 } 232 }
233 233
234 } // namespace page_load_metrics 234 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698