Made renderer-initiated requests registration more reliable.

Made renderer-initiated requests registration more reliable.

Old code relied on URLs comparisson which may give false negatives
because WKWebView allows multiple pending navigations.

This CL uses NavigationContextImpl to check if the load has been
registered previously which should always work as long as
didStartProvisionalNavigation: is guaranteed to be called.

If didStartProvisionalNavigation: is always called, then it should fix
crbug.com/725958 crash and if it's not, then didFinishNavigation: will
have to register loading request as well (which will be done in a
separate CL if needed).

BUG=727289
Review-Url: https://codereview.chromium.org/2901293003
Cr-Commit-Position: refs/heads/master@{#475698}
Committed: https://chromium.googlesource.com/chromium/src/+/19b7db898be96b32cec6d78966abe4ef613f1708

[Eugene But (OOO till 7-30), 2017-05-24 18:50:03]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 18:51:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 19:07:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:07:03]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-24 22:55:28]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 22:56:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 23:25:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 23:25:58]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-25 15:14:27]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 15:14:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 16:31:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 16:31:15]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-25 16:37:29]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[Eugene But (OOO till 7-30), 2017-05-30 15:23:04]

Description was changed from

==========
Made renderer-initiated requests registration more reliable.

Old code relied on URLs comparisson which may give false negatives
because WKWebView allows multiple pending navigations.

This CL uses NavigationContextImpl to check if the load has been
registered previously which should always work as long as
didStartProvisionalNavigation: is guaranteed to be called.

If didStartProvisionalNavigation: is always called, then it should fix
crbug.com/725958 crash and if it's not, then didFinishNavigation: will
have to register loading request as well (which will be done in a
separate CL if needed).

BUG=725958
==========

to

==========
Made renderer-initiated requests registration more reliable.

Old code relied on URLs comparisson which may give false negatives
because WKWebView allows multiple pending navigations.

This CL uses NavigationContextImpl to check if the load has been
registered previously which should always work as long as
didStartProvisionalNavigation: is guaranteed to be called.

If didStartProvisionalNavigation: is always called, then it should fix
crbug.com/725958 crash and if it's not, then didFinishNavigation: will
have to register loading request as well (which will be done in a
separate CL if needed).

BUG=727289
==========

[Eugene But (OOO till 7-30), 2017-05-30 21:21:09]

Kurt?

[kkhorimoto, 2017-05-30 21:32:13]

lgtm, sorry for the delay

[Eugene But (OOO till 7-30), 2017-05-30 23:07:06]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-05-30 23:07:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 23:54:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496185626962200,
"parent_rev": "2da93ede2753388669627579529beaa1c03548f5", "commit_rev":
"19b7db898be96b32cec6d78966abe4ef613f1708"}

[commit-bot: I haz the power, 2017-05-30 23:54:37]

Description was changed from

==========
Made renderer-initiated requests registration more reliable.

Old code relied on URLs comparisson which may give false negatives
because WKWebView allows multiple pending navigations.

This CL uses NavigationContextImpl to check if the load has been
registered previously which should always work as long as
didStartProvisionalNavigation: is guaranteed to be called.

If didStartProvisionalNavigation: is always called, then it should fix
crbug.com/725958 crash and if it's not, then didFinishNavigation: will
have to register loading request as well (which will be done in a
separate CL if needed).

BUG=727289
==========

to

==========
Made renderer-initiated requests registration more reliable.

Old code relied on URLs comparisson which may give false negatives
because WKWebView allows multiple pending navigations.

This CL uses NavigationContextImpl to check if the load has been
registered previously which should always work as long as
didStartProvisionalNavigation: is guaranteed to be called.

If didStartProvisionalNavigation: is always called, then it should fix
crbug.com/725958 crash and if it's not, then didFinishNavigation: will
have to register loading request as well (which will be done in a
separate CL if needed).

BUG=727289

Review-Url: https://codereview.chromium.org/2901293003
Cr-Commit-Position: refs/heads/master@{#475698}
Committed:
https://chromium.googlesource.com/chromium/src/+/19b7db898be96b32cec6d78966ab...
==========

[commit-bot: I haz the power, 2017-05-30 23:54:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/19b7db898be96b32cec6d78966ab...