Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: ios/web/navigation/navigation_manager_util_unittest.mm

Issue 2901293003: Made renderer-initiated requests registration more reliable. (Closed)
Patch Set: Cleaned up Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/navigation_manager_util.mm ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/navigation_manager_util_unittest.mm
diff --git a/ios/web/navigation/navigation_manager_util_unittest.mm b/ios/web/navigation/navigation_manager_util_unittest.mm
index da2297af2fcbf3ede86da7ea59eb4959d42229f7..1b26ca6b553c796848e40a0b6c55dff295b508d6 100644
--- a/ios/web/navigation/navigation_manager_util_unittest.mm
+++ b/ios/web/navigation/navigation_manager_util_unittest.mm
@@ -34,8 +34,8 @@ class NavigationManagerUtilTest : public PlatformTest {
TestBrowserState browser_state_;
};
-// Tests GetCommittedItemWithUniqueID and GetCommittedItemIndexWithUniqueID
-// functions.
+// Tests GetCommittedItemWithUniqueID, GetCommittedItemIndexWithUniqueID and
+// GetItemWithUniqueID functions.
TEST_F(NavigationManagerUtilTest, GetCommittedItemWithUniqueID) {
// Start with NavigationManager that only has a pending item.
manager_.AddPendingItem(
@@ -45,16 +45,26 @@ TEST_F(NavigationManagerUtilTest, GetCommittedItemWithUniqueID) {
NavigationItem* item = manager_.GetPendingItem();
int unique_id = item->GetUniqueID();
EXPECT_FALSE(GetCommittedItemWithUniqueID(&manager_, unique_id));
+ EXPECT_EQ(item, GetItemWithUniqueID(&manager_, unique_id));
EXPECT_EQ(-1, GetCommittedItemIndexWithUniqueID(&manager_, unique_id));
// Commit that pending item.
[controller_ commitPendingItem];
EXPECT_EQ(item, GetCommittedItemWithUniqueID(&manager_, unique_id));
+ EXPECT_EQ(item, GetItemWithUniqueID(&manager_, unique_id));
EXPECT_EQ(0, GetCommittedItemIndexWithUniqueID(&manager_, unique_id));
// Remove committed item.
manager_.RemoveItemAtIndex(0);
EXPECT_FALSE(GetCommittedItemWithUniqueID(&manager_, unique_id));
+ EXPECT_FALSE(GetItemWithUniqueID(&manager_, unique_id));
+ EXPECT_EQ(-1, GetCommittedItemIndexWithUniqueID(&manager_, unique_id));
+
+ // Add transient item.
+ [controller_ addTransientItemWithURL:GURL("http://chromium.org")];
+ item = manager_.GetTransientItem();
+ EXPECT_FALSE(GetCommittedItemWithUniqueID(&manager_, unique_id));
+ EXPECT_EQ(item, GetItemWithUniqueID(&manager_, unique_id));
EXPECT_EQ(-1, GetCommittedItemIndexWithUniqueID(&manager_, unique_id));
}
« no previous file with comments | « ios/web/navigation/navigation_manager_util.mm ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698