Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2901193002:
Fix nullptr dereference of ToolbarActionView (Closed)
|
Created:
3 years, 7 months ago by Tom Anderson Modified:
3 years, 7 months ago Reviewers:
Devlin CC:
chromium-reviews, tfarina, Nico Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix nullptr dereference of ToolbarActionView
BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval
fails when using the latest libc++ and libc++abi [1].
Frame 20 in the stack trace in [2] nulls the pointer but did not
remove the ToolbarActionView from the vector (yet). Frame 3 then
tries to use the null pointer.
This CL is necessary to roll buildtools (contains libc++ and
libc++abi) to the latest revision.
[1] https://codereview.chromium.org/2888383005/
[2] https://paste.googleplex.com/5158886495485952
BUG=593874, 717554
TBR=finnur@chromium.org
Review-Url: https://codereview.chromium.org/2901193002
Cr-Commit-Position: refs/heads/master@{#474364}
Committed: https://chromium.googlesource.com/chromium/src/+/1899d987d016dc588d677d7a8b851379aca2bdaa
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 22 (17 generated)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
finnur@ ptal
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix nullptr dereference of ToolbarActionView BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval fails when using the latest libc++ and libc++abi [1]. Frame 20 in the stack trace in [2] nulls the pointer but did not remove the ToolbarActionView from the vector (yet). Frame 3 then tries to use the null pointer. This CL is necessary to roll buildtools (contains libc++ and libc++abi) to the latest revision. [1] https://codereview.chromium.org/2888383005/ [2] https://paste.googleplex.com/5158886495485952 BUG=593874 R=finnur@chromium.org ========== to ========== Fix nullptr dereference of ToolbarActionView BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval fails when using the latest libc++ and libc++abi [1]. Frame 20 in the stack trace in [2] nulls the pointer but did not remove the ToolbarActionView from the vector (yet). Frame 3 then tries to use the null pointer. This CL is necessary to roll buildtools (contains libc++ and libc++abi) to the latest revision. [1] https://codereview.chromium.org/2888383005/ [2] https://paste.googleplex.com/5158886495485952 BUG=593874 TBR=finnur@chromium.org ==========
The CQ bit was checked by thomasanderson@chromium.org
The CQ bit was unchecked by thomasanderson@chromium.org
finnur@chromium.org changed reviewers: + rdevlin.cronin@chromium.org - finnur@chromium.org
Devlin has been more involved than me in the lifetime issues of this container and is therefore a better reviewer for this.
I think this will work. LGTM. +Nico who was looking into this at one point as well.
The CQ bit was checked by thomasanderson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix nullptr dereference of ToolbarActionView BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval fails when using the latest libc++ and libc++abi [1]. Frame 20 in the stack trace in [2] nulls the pointer but did not remove the ToolbarActionView from the vector (yet). Frame 3 then tries to use the null pointer. This CL is necessary to roll buildtools (contains libc++ and libc++abi) to the latest revision. [1] https://codereview.chromium.org/2888383005/ [2] https://paste.googleplex.com/5158886495485952 BUG=593874 TBR=finnur@chromium.org ========== to ========== Fix nullptr dereference of ToolbarActionView BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval fails when using the latest libc++ and libc++abi [1]. Frame 20 in the stack trace in [2] nulls the pointer but did not remove the ToolbarActionView from the vector (yet). Frame 3 then tries to use the null pointer. This CL is necessary to roll buildtools (contains libc++ and libc++abi) to the latest revision. [1] https://codereview.chromium.org/2888383005/ [2] https://paste.googleplex.com/5158886495485952 BUG=593874,717554 TBR=finnur@chromium.org ==========
Description was changed from ========== Fix nullptr dereference of ToolbarActionView BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval fails when using the latest libc++ and libc++abi [1]. Frame 20 in the stack trace in [2] nulls the pointer but did not remove the ToolbarActionView from the vector (yet). Frame 3 then tries to use the null pointer. This CL is necessary to roll buildtools (contains libc++ and libc++abi) to the latest revision. [1] https://codereview.chromium.org/2888383005/ [2] https://paste.googleplex.com/5158886495485952 BUG=593874,717554 TBR=finnur@chromium.org ========== to ========== Fix nullptr dereference of ToolbarActionView BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval fails when using the latest libc++ and libc++abi [1]. Frame 20 in the stack trace in [2] nulls the pointer but did not remove the ToolbarActionView from the vector (yet). Frame 3 then tries to use the null pointer. This CL is necessary to roll buildtools (contains libc++ and libc++abi) to the latest revision. [1] https://codereview.chromium.org/2888383005/ [2] https://paste.googleplex.com/5158886495485952 BUG=593874,717554 ==========
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495650253342350, "parent_rev":
"e713cd4c5b8995854329af72ea0ec3be7eb945f8", "commit_rev":
"1899d987d016dc588d677d7a8b851379aca2bdaa"}
Message was sent while issue was closed.
Description was changed from ========== Fix nullptr dereference of ToolbarActionView BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval fails when using the latest libc++ and libc++abi [1]. Frame 20 in the stack trace in [2] nulls the pointer but did not remove the ToolbarActionView from the vector (yet). Frame 3 then tries to use the null pointer. This CL is necessary to roll buildtools (contains libc++ and libc++abi) to the latest revision. [1] https://codereview.chromium.org/2888383005/ [2] https://paste.googleplex.com/5158886495485952 BUG=593874,717554 ========== to ========== Fix nullptr dereference of ToolbarActionView BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval fails when using the latest libc++ and libc++abi [1]. Frame 20 in the stack trace in [2] nulls the pointer but did not remove the ToolbarActionView from the vector (yet). Frame 3 then tries to use the null pointer. This CL is necessary to roll buildtools (contains libc++ and libc++abi) to the latest revision. [1] https://codereview.chromium.org/2888383005/ [2] https://paste.googleplex.com/5158886495485952 BUG=593874,717554 TBR=finnur@chromium.org Review-Url: https://codereview.chromium.org/2901193002 Cr-Commit-Position: refs/heads/master@{#474364} Committed: https://chromium.googlesource.com/chromium/src/+/1899d987d016dc588d677d7a8b85... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1899d987d016dc588d677d7a8b85... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
