Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2888383005:
Roll buildtools to 57c9408 (Closed)
|
Created:
3 years, 7 months ago by Tom Anderson Modified:
3 years, 7 months ago CC:
chromium-reviews, Nico Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll buildtools to 57c9408
This is needed to pick up:
https://codereview.chromium.org/2897463004
https://codereview.chromium.org/2848383002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
BUG=593874, 709456
R=thestig@chromium.org
Review-Url: https://codereview.chromium.org/2888383005
Cr-Commit-Position: refs/heads/master@{#474425}
Committed: https://chromium.googlesource.com/chromium/src/+/2064d334c9817b83d54f945e03edd2c7e626b128
Patch Set 1 #Patch Set 2 : Add dependency patchset #Messages
Total messages: 35 (27 generated)
Description was changed from ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002/ BUG=593874 TBR=thestig@chromium.org ========== to ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002/ BUG=593874,709456 TBR=thestig@chromium.org ==========
Description was changed from ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002/ BUG=593874,709456 TBR=thestig@chromium.org ========== to ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002/ CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 TBR=thestig@chromium.org ==========
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_msan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002/ CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 TBR=thestig@chromium.org ========== to ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002/ CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 TBR=thestig@chromium.org ==========
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002/ CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 TBR=thestig@chromium.org ========== to ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 TBR=thestig@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Description was changed from ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 TBR=thestig@chromium.org ========== to ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 R=thestig@chromium.org ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + thakis@chromium.org
Hm, this is blocked on figuring out https://codereview.chromium.org/2857653002/ . Maybe we should just disable that one test under asan though.
(because see red bot on https://codereview.chromium.org/2854703002/ ) On Wed, May 24, 2017 at 2:20 PM, <thakis@chromium.org> wrote: > Hm, this is blocked on figuring out https://codereview.chromium. > org/2857653002/ > . Maybe we should just disable that one test under asan though. > > https://codereview.chromium.org/2888383005/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2017/05/24 18:20:16, Nico wrote: > Hm, this is blocked on figuring out https://codereview.chromium.org/2857653002/ > . Maybe we should just disable that one test under asan though. ptal at the dependency patch set
Oh, neat :-) On Wed, May 24, 2017 at 2:24 PM, <thomasanderson@chromium.org> wrote: > On 2017/05/24 18:20:16, Nico wrote: > > Hm, this is blocked on figuring out > https://codereview.chromium.org/2857653002/ > > . Maybe we should just disable that one test under asan though. > > ptal at the dependency patch set > > https://codereview.chromium.org/2888383005/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm
Description was changed from ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 R=thestig@chromium.org ========== to ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456,717554 R=thestig@chromium.org ==========
Description was changed from ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456,717554 R=thestig@chromium.org ========== to ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 R=thestig@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495660128996570,
"parent_rev": "b12d5fd88a73bed357687b9287e9cdebdf1d217b", "commit_rev":
"2064d334c9817b83d54f945e03edd2c7e626b128"}
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 R=thestig@chromium.org ========== to ========== Roll buildtools to 57c9408 This is needed to pick up: https://codereview.chromium.org/2897463004 https://codereview.chromium.org/2848383002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=593874,709456 R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2888383005 Cr-Commit-Position: refs/heads/master@{#474425} Committed: https://chromium.googlesource.com/chromium/src/+/2064d334c9817b83d54f945e03ed... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2064d334c9817b83d54f945e03ed... |
