Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2901163002: Use assembly instead of C array literals to link the core snapshot into the VM. (Closed)

Created:
3 years, 7 months ago by rmacnak
Modified:
3 years, 7 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use assembly instead of C array literals to link the core snapshot into the VM. Allows for including instructions. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/14ec8fa9793e072fbeeed1e85fa513bef30184b7

Patch Set 1 #

Patch Set 2 : account for mac name mangling #

Patch Set 3 : format #

Patch Set 4 : . #

Total comments: 28

Patch Set 5 : . #

Patch Set 6 : windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -61 lines) Patch
M build/toolchain/win/BUILD.gn View 1 2 3 4 5 1 chunk +8 lines, -3 lines 0 comments Download
M runtime/bin/BUILD.gn View 1 2 3 4 1 chunk +74 lines, -27 lines 0 comments Download
M runtime/bin/bin.gypi View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M runtime/bin/main.cc View 1 2 3 1 chunk +18 lines, -4 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 2 3 4 2 chunks +16 lines, -4 lines 0 comments Download
M runtime/bin/snapshot_empty.cc View 1 2 1 chunk +6 lines, -10 lines 0 comments Download
M runtime/bin/snapshot_in.cc View 1 2 3 4 1 chunk +6 lines, -11 lines 0 comments Download
A runtime/tools/bin_to_assembly.py View 1 2 3 4 5 1 chunk +94 lines, -0 lines 0 comments Download
A runtime/tools/empty.bin View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gyp/configurations_make.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
rmacnak
Not yet tested on Windows. https://codereview.chromium.org/2901163002/diff/60001/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/2901163002/diff/60001/runtime/bin/main.cc#newcode51 runtime/bin/main.cc:51: const uint8_t* vm_snapshot_data = ...
3 years, 7 months ago (2017-05-24 01:08:04 UTC) #4
zra
https://codereview.chromium.org/2901163002/diff/60001/runtime/bin/BUILD.gn File runtime/bin/BUILD.gn (right): https://codereview.chromium.org/2901163002/diff/60001/runtime/bin/BUILD.gn#newcode492 runtime/bin/BUILD.gn:492: template("bin_to_assembly") { Please add comment describing what this does, ...
3 years, 7 months ago (2017-05-24 16:20:32 UTC) #5
rmacnak
https://codereview.chromium.org/2901163002/diff/60001/runtime/bin/BUILD.gn File runtime/bin/BUILD.gn (right): https://codereview.chromium.org/2901163002/diff/60001/runtime/bin/BUILD.gn#newcode492 runtime/bin/BUILD.gn:492: template("bin_to_assembly") { On 2017/05/24 16:20:24, zra wrote: > Please ...
3 years, 7 months ago (2017-05-24 19:26:46 UTC) #6
zra
lgtm
3 years, 7 months ago (2017-05-24 19:37:06 UTC) #7
rmacnak
On 2017/05/24 19:37:06, zra wrote: > lgtm Added Windows fixes from Zach's machine.
3 years, 7 months ago (2017-05-24 21:37:41 UTC) #8
rmacnak
3 years, 7 months ago (2017-05-24 21:38:21 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
14ec8fa9793e072fbeeed1e85fa513bef30184b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698