Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: runtime/bin/snapshot_in.cc

Issue 2901163002: Use assembly instead of C array literals to link the core snapshot into the VM. (Closed)
Patch Set: windows Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/snapshot_empty.cc ('k') | runtime/tools/bin_to_assembly.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/snapshot_in.cc
diff --git a/runtime/bin/snapshot_in.cc b/runtime/bin/snapshot_in.cc
index 8445c20b41ca573e7f32a52d4a16cb52bdbea36b..544d830211be537240c92e7e153aa3e57fe48117 100644
--- a/runtime/bin/snapshot_in.cc
+++ b/runtime/bin/snapshot_in.cc
@@ -15,29 +15,24 @@ typedef unsigned __int8 uint8_t;
#endif
#include <stddef.h>
-namespace dart {
-namespace bin {
+extern "C" {
// The string on the next line will be filled in with the contents of the
// generated snapshot binary file for the vm isolate.
// This string forms the content of a vm isolate snapshot which is loaded
// into the vm isolate.
-static const uint8_t vm_snapshot_data_[] = {
+uint8_t kDartVmSnapshotData[] = {
%s
};
-const uint8_t* vm_snapshot_data = vm_snapshot_data_;
-const uint8_t* vm_snapshot_instructions = NULL;
-
+uint8_t kDartVmSnapshotInstructions[] = {};
// The string on the next line will be filled in with the contents of the
// generated snapshot binary file for a regular dart isolate.
// This string forms the content of a regular dart isolate snapshot which is
// loaded into an isolate when it is created.
-static const uint8_t core_isolate_snapshot_data_[] = {
+uint8_t kDartCoreIsolateSnapshotData[] = {
%s
};
-const uint8_t* core_isolate_snapshot_data = core_isolate_snapshot_data_;
-const uint8_t* core_isolate_snapshot_instructions = NULL;
+uint8_t kDartCoreIsolateSnapshotInstructions[] = {};
-} // namespace bin
-} // namespace dart
+}
« no previous file with comments | « runtime/bin/snapshot_empty.cc ('k') | runtime/tools/bin_to_assembly.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698