Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2901133002: DevTools: Disable Audits2 buttons when service worker is active (Closed)

Created:
3 years, 7 months ago by phulce
Modified:
3 years, 7 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Disable Audits2 buttons when service worker is active * Displays help text on the dialog when a service worker is active or no category is selected * Disables the dialog start button when a service worker is active BUG=723411 Review-Url: https://codereview.chromium.org/2901133002 Cr-Commit-Position: refs/heads/master@{#474158} Committed: https://chromium.googlesource.com/chromium/src/+/23da751ab184c42ed88c67e150c316878105211e

Patch Set 1 #

Total comments: 2

Patch Set 2 : add stack logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -13 lines) Patch
M third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js View 4 chunks +86 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/audits2Dialog.css View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/worker_service/ServiceDispatcher.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
phulce
3 years, 7 months ago (2017-05-23 21:37:04 UTC) #2
caseq
https://codereview.chromium.org/2901133002/diff/1/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js (right): https://codereview.chromium.org/2901133002/diff/1/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js#newcode54 third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:54: modelAdded(serviceWorkerManager) { Use SDK.targetManager.addModelListener() instead?
3 years, 7 months ago (2017-05-23 21:44:00 UTC) #4
phulce
https://codereview.chromium.org/2901133002/diff/1/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js (right): https://codereview.chromium.org/2901133002/diff/1/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js#newcode54 third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:54: modelAdded(serviceWorkerManager) { On 2017/05/23 21:44:00, caseq wrote: > Use ...
3 years, 7 months ago (2017-05-23 22:13:32 UTC) #5
pfeldman
lgtm
3 years, 7 months ago (2017-05-23 22:34:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901133002/20001
3 years, 7 months ago (2017-05-23 23:19:56 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 04:15:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/23da751ab184c42ed88c67e150c3...

Powered by Google App Engine
This is Rietveld 408576698