DevTools: Disable Audits2 buttons when service worker is active

DevTools: Disable Audits2 buttons when service worker is active

* Displays help text on the dialog when a service worker is active or no category is selected
* Disables the dialog start button when a service worker is active

BUG=723411
Review-Url: https://codereview.chromium.org/2901133002
Cr-Commit-Position: refs/heads/master@{#474158}
Committed: https://chromium.googlesource.com/chromium/src/+/23da751ab184c42ed88c67e150c316878105211e

[phulce, 2017-05-23 21:37:03]

phulce@chromium.org changed reviewers:
+ pfeldman@chromium.org

[caseq, 2017-05-23 21:44:00]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-05-23 21:44:00]

https://codereview.chromium.org/2901133002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2901133002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:54:
modelAdded(serviceWorkerManager) {
Use SDK.targetManager.addModelListener() instead?

[phulce, 2017-05-23 22:13:32]

https://codereview.chromium.org/2901133002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2901133002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:54:
modelAdded(serviceWorkerManager) {
On 2017/05/23 21:44:00, caseq wrote:
> Use SDK.targetManager.addModelListener() instead?

Talked to pavel about this too, it's somewhat convenient and more readable in
_hasActiveServiceWorker to let the manager do the bookkeeping on the
registrations and versions so that we can just loop through them whenever we
want. There should only ever be one manager so we won't be wasting too many
cycles on adding event and removing event listeners. 

Is there another benefit to using addModelListener we might have missed?

[pfeldman, 2017-05-23 22:34:36]

lgtm

[phulce, 2017-05-23 23:18:12]

The CQ bit was checked by phulce@chromium.org

[phulce, 2017-05-23 23:18:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2901133002/#ps20001
(title: "add stack logging")

[commit-bot: I haz the power, 2017-05-23 23:19:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 04:15:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495581492631120,
"parent_rev": "43017673005af77aba9dc160a4c1ee4ee47076ff", "commit_rev":
"23da751ab184c42ed88c67e150c316878105211e"}

[commit-bot: I haz the power, 2017-05-24 04:15:08]

Description was changed from

==========
DevTools: Disable Audits2 buttons when service worker is active

* Displays help text on the dialog when a service worker is active or no
category is selected
* Disables the dialog start button when a service worker is active

BUG=723411
==========

to

==========
DevTools: Disable Audits2 buttons when service worker is active

* Displays help text on the dialog when a service worker is active or no
category is selected
* Disables the dialog start button when a service worker is active

BUG=723411

Review-Url: https://codereview.chromium.org/2901133002
Cr-Commit-Position: refs/heads/master@{#474158}
Committed:
https://chromium.googlesource.com/chromium/src/+/23da751ab184c42ed88c67e150c3...
==========

[commit-bot: I haz the power, 2017-05-24 04:15:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/23da751ab184c42ed88c67e150c3...