Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2901093007: android: switch from gcc to clang (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Torne, pasko, jbudorick
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed – clang-built binaries on Arm are now a few 100 kB smaller than with gcc. (The Android kernel is now also built in this configuration that we are going to use.) Given that Android supports 6 ISAs, this will probably break some bot that I don't know about. If that happens, please file a bug for that and revert. This should be safe to revert. I ran these perf try jobs: tools/perf/run_benchmark try android-one blink_perf.dom tools/perf/run_benchmark try android-one blink_perf.bindings tools/perf/run_benchmark try android-one thread_times.key_silk_cases tools/perf/run_benchmark try android-nexus5X blink_perf.dom tools/perf/run_benchmark try android-nexus5X blink_perf.bindings tools/perf/run_benchmark try android-nexus5X thread_times.key_silk_cases Results: https://bugs.chromium.org/p/chromium/issues/detail?id=481675#c31 BUG=481675 Review-Url: https://codereview.chromium.org/2901093007 Cr-Commit-Position: refs/heads/master@{#478517} Committed: https://chromium.googlesource.com/chromium/src/+/f823f843f06636feb082521d76c282a16fe2d577

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : undo _NormalizeZip() removal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/BUILDCONFIG.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 72 (60 generated)
Nico
3 years, 6 months ago (2017-05-30 01:03:25 UTC) #11
Primiano Tucci (use gerrit)
LGTM Good luck with things like armv6 cronet or internal big-endian-29-bits MIPS bots. If this ...
3 years, 6 months ago (2017-05-30 08:52:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901093007/1
3 years, 6 months ago (2017-05-30 08:53:25 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/450554)
3 years, 6 months ago (2017-05-30 09:01:04 UTC) #18
Nico
+brettw for owners. (See "Moving clank to clang arch-by-arch" on internal clank-team, but since gcc ...
3 years, 6 months ago (2017-05-30 20:12:58 UTC) #20
brettw
LGTM, good luck.
3 years, 6 months ago (2017-05-30 22:09:02 UTC) #21
Primiano Tucci (use gerrit)
http://i.imgur.com/UUiukmP.gif
3 years, 6 months ago (2017-05-31 10:45:22 UTC) #22
agrieve
On 2017/05/31 10:45:22, Primiano Tucci wrote: > http://i.imgur.com/UUiukmP.gif Note: although bots are now passing, today's ...
3 years, 6 months ago (2017-06-07 14:54:00 UTC) #56
Nico
On 2017/06/07 14:54:00, agrieve wrote: > On 2017/05/31 10:45:22, Primiano Tucci wrote: > > http://i.imgur.com/UUiukmP.gif ...
3 years, 6 months ago (2017-06-07 17:36:42 UTC) #57
agrieve
On 2017/06/07 17:36:42, Nico (vacation Jun 3-11) wrote: > On 2017/06/07 14:54:00, agrieve wrote: > ...
3 years, 6 months ago (2017-06-07 19:42:37 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901093007/40001
3 years, 6 months ago (2017-06-10 17:30:38 UTC) #69
commit-bot: I haz the power
3 years, 6 months ago (2017-06-10 17:34:00 UTC) #72
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f823f843f06636feb082521d76c2...

Powered by Google App Engine
This is Rietveld 408576698