|
|
Descriptionandroid: switch from gcc to clang.
gcc has been deprecated in the NDK for a while.
The blocker here was binary size, but after
https://codereview.chromium.org/2897283002 that's fixed – clang-built binaries
on Arm are now a few 100 kB smaller than with gcc. (The Android kernel is
now also built in this configuration that we are going to use.)
Given that Android supports 6 ISAs, this will probably break
some bot that I don't know about. If that happens, please file
a bug for that and revert. This should be safe to revert.
I ran these perf try jobs:
tools/perf/run_benchmark try android-one blink_perf.dom
tools/perf/run_benchmark try android-one blink_perf.bindings
tools/perf/run_benchmark try android-one thread_times.key_silk_cases
tools/perf/run_benchmark try android-nexus5X blink_perf.dom
tools/perf/run_benchmark try android-nexus5X blink_perf.bindings
tools/perf/run_benchmark try android-nexus5X thread_times.key_silk_cases
Results:
https://bugs.chromium.org/p/chromium/issues/detail?id=481675#c31
BUG=481675
Review-Url: https://codereview.chromium.org/2901093007
Cr-Commit-Position: refs/heads/master@{#478517}
Committed: https://chromium.googlesource.com/chromium/src/+/f823f843f06636feb082521d76c282a16fe2d577
Patch Set 1 #Patch Set 2 : test #Patch Set 3 : undo _NormalizeZip() removal #Messages
Total messages: 72 (60 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed (and it's also how the android kernel is built now). BUG=481675 ========== to ========== android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed (and it's also how the android kernel is built now). Given that Android supports 6 ISAs, this will probably break some bot that I don't know about. If that happens, please file a bug for that and revert. This should be safe to revert. BUG=481675 ==========
Description was changed from ========== android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed (and it's also how the android kernel is built now). Given that Android supports 6 ISAs, this will probably break some bot that I don't know about. If that happens, please file a bug for that and revert. This should be safe to revert. BUG=481675 ========== to ========== android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed (and it's also how the android kernel is built now). Given that Android supports 6 ISAs, this will probably break some bot that I don't know about. If that happens, please file a bug for that and revert. This should be safe to revert. I ran these perf try jobs: tools/perf/run_benchmark try android-one blink_perf.dom tools/perf/run_benchmark try android-one blink_perf.bindings tools/perf/run_benchmark try android-one thread_times.key_silk_cases tools/perf/run_benchmark try android-nexus5X blink_perf.dom tools/perf/run_benchmark try android-nexus5X blink_perf.bindings tools/perf/run_benchmark try android-nexus5X thread_times.key_silk_cases BUG=481675 ==========
The CQ bit was unchecked by thakis@chromium.org
Description was changed from ========== android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed (and it's also how the android kernel is built now). Given that Android supports 6 ISAs, this will probably break some bot that I don't know about. If that happens, please file a bug for that and revert. This should be safe to revert. I ran these perf try jobs: tools/perf/run_benchmark try android-one blink_perf.dom tools/perf/run_benchmark try android-one blink_perf.bindings tools/perf/run_benchmark try android-one thread_times.key_silk_cases tools/perf/run_benchmark try android-nexus5X blink_perf.dom tools/perf/run_benchmark try android-nexus5X blink_perf.bindings tools/perf/run_benchmark try android-nexus5X thread_times.key_silk_cases BUG=481675 ========== to ========== android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed (and it's also how the android kernel is built now). Given that Android supports 6 ISAs, this will probably break some bot that I don't know about. If that happens, please file a bug for that and revert. This should be safe to revert. I ran these perf try jobs: tools/perf/run_benchmark try android-one blink_perf.dom tools/perf/run_benchmark try android-one blink_perf.bindings tools/perf/run_benchmark try android-one thread_times.key_silk_cases tools/perf/run_benchmark try android-nexus5X blink_perf.dom tools/perf/run_benchmark try android-nexus5X blink_perf.bindings tools/perf/run_benchmark try android-nexus5X thread_times.key_silk_cases Results: https://bugs.chromium.org/p/chromium/issues/detail?id=481675#c31 BUG=481675 ==========
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed (and it's also how the android kernel is built now). Given that Android supports 6 ISAs, this will probably break some bot that I don't know about. If that happens, please file a bug for that and revert. This should be safe to revert. I ran these perf try jobs: tools/perf/run_benchmark try android-one blink_perf.dom tools/perf/run_benchmark try android-one blink_perf.bindings tools/perf/run_benchmark try android-one thread_times.key_silk_cases tools/perf/run_benchmark try android-nexus5X blink_perf.dom tools/perf/run_benchmark try android-nexus5X blink_perf.bindings tools/perf/run_benchmark try android-nexus5X thread_times.key_silk_cases Results: https://bugs.chromium.org/p/chromium/issues/detail?id=481675#c31 BUG=481675 ========== to ========== android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed – clang-built binaries on Arm are now a few 100 kB smaller than with gcc. (The Android kernel is now also built in this configuration that we are going to use.) Given that Android supports 6 ISAs, this will probably break some bot that I don't know about. If that happens, please file a bug for that and revert. This should be safe to revert. I ran these perf try jobs: tools/perf/run_benchmark try android-one blink_perf.dom tools/perf/run_benchmark try android-one blink_perf.bindings tools/perf/run_benchmark try android-one thread_times.key_silk_cases tools/perf/run_benchmark try android-nexus5X blink_perf.dom tools/perf/run_benchmark try android-nexus5X blink_perf.bindings tools/perf/run_benchmark try android-nexus5X thread_times.key_silk_cases Results: https://bugs.chromium.org/p/chromium/issues/detail?id=481675#c31 BUG=481675 ==========
thakis@chromium.org changed reviewers: + primiano@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
LGTM Good luck with things like armv6 cronet or internal big-endian-29-bits MIPS bots. If this sticks within 2 reverts I'll pay you a beer ;-)
The CQ bit was checked by primiano@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
thakis@chromium.org changed reviewers: + brettw@chromium.org
+brettw for owners. (See "Moving clank to clang arch-by-arch" on internal clank-team, but since gcc is deprecated in the NDK maybe this switch is less surprising than the Win one anyways.)
LGTM, good luck.
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/31 10:45:22, Primiano Tucci wrote: > http://i.imgur.com/UUiukmP.gif Note: although bots are now passing, today's probably not a good day to check this in since our bot fleet on the whole are having timeout issues.
On 2017/06/07 14:54:00, agrieve wrote: > On 2017/05/31 10:45:22, Primiano Tucci wrote: > > http://i.imgur.com/UUiukmP.gif > > Note: although bots are now passing, today's probably not a good day to check > this in since our bot fleet on the whole are having timeout issues. Do you have a tracking bug for that I can follow?
On 2017/06/07 17:36:42, Nico (vacation Jun 3-11) wrote: > On 2017/06/07 14:54:00, agrieve wrote: > > On 2017/05/31 10:45:22, Primiano Tucci wrote: > > > http://i.imgur.com/UUiukmP.gif > > > > Note: although bots are now passing, today's probably not a good day to check > > this in since our bot fleet on the whole are having timeout issues. > > Do you have a tracking bug for that I can follow? https://bugs.chromium.org/p/chromium/issues/detail?id=725224 I'm hoping it's fixed now, but should give it a day and see.
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, brettw@chromium.org Link to the patchset: https://codereview.chromium.org/2901093007/#ps40001 (title: "undo _NormalizeZip() removal")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497115823164830, "parent_rev": "74bf3d028824e0cb58519bd18839490f89bf7ac1", "commit_rev": "f823f843f06636feb082521d76c282a16fe2d577"}
Message was sent while issue was closed.
Description was changed from ========== android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed – clang-built binaries on Arm are now a few 100 kB smaller than with gcc. (The Android kernel is now also built in this configuration that we are going to use.) Given that Android supports 6 ISAs, this will probably break some bot that I don't know about. If that happens, please file a bug for that and revert. This should be safe to revert. I ran these perf try jobs: tools/perf/run_benchmark try android-one blink_perf.dom tools/perf/run_benchmark try android-one blink_perf.bindings tools/perf/run_benchmark try android-one thread_times.key_silk_cases tools/perf/run_benchmark try android-nexus5X blink_perf.dom tools/perf/run_benchmark try android-nexus5X blink_perf.bindings tools/perf/run_benchmark try android-nexus5X thread_times.key_silk_cases Results: https://bugs.chromium.org/p/chromium/issues/detail?id=481675#c31 BUG=481675 ========== to ========== android: switch from gcc to clang. gcc has been deprecated in the NDK for a while. The blocker here was binary size, but after https://codereview.chromium.org/2897283002 that's fixed – clang-built binaries on Arm are now a few 100 kB smaller than with gcc. (The Android kernel is now also built in this configuration that we are going to use.) Given that Android supports 6 ISAs, this will probably break some bot that I don't know about. If that happens, please file a bug for that and revert. This should be safe to revert. I ran these perf try jobs: tools/perf/run_benchmark try android-one blink_perf.dom tools/perf/run_benchmark try android-one blink_perf.bindings tools/perf/run_benchmark try android-one thread_times.key_silk_cases tools/perf/run_benchmark try android-nexus5X blink_perf.dom tools/perf/run_benchmark try android-nexus5X blink_perf.bindings tools/perf/run_benchmark try android-nexus5X thread_times.key_silk_cases Results: https://bugs.chromium.org/p/chromium/issues/detail?id=481675#c31 BUG=481675 Review-Url: https://codereview.chromium.org/2901093007 Cr-Commit-Position: refs/heads/master@{#478517} Committed: https://chromium.googlesource.com/chromium/src/+/f823f843f06636feb082521d76c2... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f823f843f06636feb082521d76c2... |