Fix RLZ ID generation to be 50 char and slightly more robust.

Fix RLZ ID generation to be 50 char and slightly more robust.

There was an off by one error that was making it 49 chars.  The
previous solution wouldn't work if the base ID was less than 25
chars either.  This solution should work for any non-empty ID.

TBR=yusufo@chromium.org
TEST=DCHECK doesn't fail
BUG=

Review-Url: https://codereview.chromium.org/2900963004
Cr-Commit-Position: refs/heads/master@{#473968}
Committed: https://chromium.googlesource.com/chromium/src/+/4d011265aba6c7861461ec968630efe952d8799f

[Ted C, 2017-05-23 16:13:34]

tedchoc@chromium.org changed reviewers:
+ yusufo@chromium.org

[Ted C, 2017-05-23 16:13:44]

Description was changed from

==========
Fix RLZ ID generation to be 50 char and slightly more robust.

There was an off by one error that was making it 49 chars.  The
previous solution wouldn't work if the base ID was less than 25
chars either.  This solution should work for any non-empty ID.

TEST=DCHECK doesn't fail
BUG=
==========

to

==========
Fix RLZ ID generation to be 50 char and slightly more robust.

There was an off by one error that was making it 49 chars.  The
previous solution wouldn't work if the base ID was less than 25
chars either.  This solution should work for any non-empty ID.

TBR=yusufo@chromium.org
TEST=DCHECK doesn't fail
BUG=
==========

[Yusuf, 2017-05-23 16:54:52]

lgtm

[Yusuf, 2017-05-23 16:54:57]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2017-05-23 16:55:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 17:47:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495558497999150, "parent_rev":
"9e11227e71843e73f1f577adb79188cb4bac6477", "commit_rev":
"4d011265aba6c7861461ec968630efe952d8799f"}

[commit-bot: I haz the power, 2017-05-23 17:47:35]

Description was changed from

==========
Fix RLZ ID generation to be 50 char and slightly more robust.

There was an off by one error that was making it 49 chars.  The
previous solution wouldn't work if the base ID was less than 25
chars either.  This solution should work for any non-empty ID.

TBR=yusufo@chromium.org
TEST=DCHECK doesn't fail
BUG=
==========

to

==========
Fix RLZ ID generation to be 50 char and slightly more robust.

There was an off by one error that was making it 49 chars.  The
previous solution wouldn't work if the base ID was less than 25
chars either.  This solution should work for any non-empty ID.

TBR=yusufo@chromium.org
TEST=DCHECK doesn't fail
BUG=

Review-Url: https://codereview.chromium.org/2900963004
Cr-Commit-Position: refs/heads/master@{#473968}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d011265aba6c7861461ec968630...
==========

[commit-bot: I haz the power, 2017-05-23 17:47:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d011265aba6c7861461ec968630...