Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/rlz/RlzPingHandler.java

Issue 2900963004: Fix RLZ ID generation to be 50 char and slightly more robust. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/rlz/RlzPingHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/rlz/RlzPingHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/rlz/RlzPingHandler.java
index 4ed88a7ce907f0f9b78abc78a10cdacd8c267a20..b6ab1f8e1c5892f3e673ccffecb4f0fb52ac22bc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/rlz/RlzPingHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/rlz/RlzPingHandler.java
@@ -38,12 +38,20 @@ public class RlzPingHandler {
String id =
new SettingsSecureBasedIdentificationGenerator(ContextUtils.getApplicationContext())
.getUniqueId(ID_SALT);
- id = id + id.substring(0, 50 - id.length() - 1);
+ id = generate50CharacterId(id);
nativeStartPing(Profile.getLastUsedProfile().getOriginalProfile(), brand,
Locale.getDefault().getLanguage(), TextUtils.join(",", events), id, callback);
}
+ private static String generate50CharacterId(String baseId) {
+ StringBuilder idBuilder = new StringBuilder();
+ while (idBuilder.length() < 50) {
+ idBuilder.append(baseId);
+ }
+ return idBuilder.substring(0, 50);
+ }
+
private static native void nativeStartPing(Profile profile, String brand, String language,
String events, String id, Callback<Boolean> callback);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698