Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2900953004: Revert of Why do we have this line when it makes sliders look editable? (Closed)

Created:
3 years, 7 months ago by Marijn Kruisselbrink
Modified:
3 years, 7 months ago
Reviewers:
aleventhal, dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Why do we have this line when it makes sliders look editable? (patchset #2 id:20001 of https://codereview.chromium.org/2893963002/ ) Reason for revert: Is causing test failures such as https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/67395 DumpAccessibilityEventsTest.AccessibilityEventsAriaSliderValueTextChange c:\b\c\b\win\src\content\browser\accessibility\dump_accessibility_browsertest_base.cc(363): error: Value of: is_different Actual: true Expected: false [4988:5300:0523/092002.409:37981750:ERROR:dump_accessibility_browsertest_base.cc(388)] Diff: * Line Expected - ---- -------- * 1 EVENT_OBJECT_VALUECHANGE on role=ROLE_SYSTEM_SLIDER value="2%" IA2_STATE_EDITABLE,IA2_STATE_VERTICAL 2 <-- End-of-file --> Actual ------ EVENT_OBJECT_VALUECHANGE on role=ROLE_SYSTEM_SLIDER value="2%" IA2_STATE_VERTICAL <-- End-of-file --> Original issue's description: > Why do we have this line when it makes sliders look editable? > > BUG=None > > Review-Url: https://codereview.chromium.org/2893963002 > Cr-Commit-Position: refs/heads/master@{#473911} > Committed: https://chromium.googlesource.com/chromium/src/+/b78f1ba01120e4f9dfa9faf541b670d893883cfe TBR=dmazzoni@chromium.org,aleventhal@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2900953004 Cr-Commit-Position: refs/heads/master@{#473944} Committed: https://chromium.googlesource.com/chromium/src/+/ad392f2d79a27751c1dc0e7142b9497ad9042f1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Marijn Kruisselbrink
Created Revert of Why do we have this line when it makes sliders look editable?
3 years, 7 months ago (2017-05-23 16:56:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900953004/1
3 years, 7 months ago (2017-05-23 16:57:03 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 16:57:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad392f2d79a27751c1dc0e7142b9...

Powered by Google App Engine
This is Rietveld 408576698