Why do we have this line when it makes sliders look editable?

Why do we have this line when it makes sliders look editable?

BUG=None

Review-Url: https://codereview.chromium.org/2893963002
Cr-Commit-Position: refs/heads/master@{#473911}
Committed: https://chromium.googlesource.com/chromium/src/+/b78f1ba01120e4f9dfa9faf541b670d893883cfe

[aleventhal, 2017-05-18 16:54:50]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 16:55:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 18:06:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 18:06:29]

Dry run: This issue passed the CQ dry run.

[aleventhal, 2017-05-18 18:06:41]

aleventhal@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[aleventhal, 2017-05-18 18:06:42]

Looks like we don't need it.

[dmazzoni, 2017-05-19 19:47:56]

Makes sense to me.

This will clash with this change:
https://codereview.chromium.org/2799413002/

It looks like editable, readonly, and can_set_value
are redundant - we only need 2 of those 3.

[aleventhal, 2017-05-23 02:25:20]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 02:25:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-05-23 03:27:09]

Rebased & ready for review

[commit-bot: I haz the power, 2017-05-23 03:39:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 03:39:30]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-05-23 15:37:51]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-05-23 15:37:52]

lgtm

[commit-bot: I haz the power, 2017-05-23 15:38:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 15:43:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495553871894380,
"parent_rev": "5dbc9a7e8c5ca7a9ac4ae0ab68a6f85ca6887192", "commit_rev":
"b78f1ba01120e4f9dfa9faf541b670d893883cfe"}

[commit-bot: I haz the power, 2017-05-23 15:43:44]

Description was changed from

==========
Why do we have this line when it makes sliders look editable?

BUG=None
==========

to

==========
Why do we have this line when it makes sliders look editable?

BUG=None

Review-Url: https://codereview.chromium.org/2893963002
Cr-Commit-Position: refs/heads/master@{#473911}
Committed:
https://chromium.googlesource.com/chromium/src/+/b78f1ba01120e4f9dfa9faf541b6...
==========

[commit-bot: I haz the power, 2017-05-23 15:43:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b78f1ba01120e4f9dfa9faf541b6...

[Marijn Kruisselbrink, 2017-05-23 16:56:27]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2900953004/ by mek@chromium.org.

The reason for reverting is: Is causing test failures such as
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...

DumpAccessibilityEventsTest.AccessibilityEventsAriaSliderValueTextChange

c:\b\c\b\win\src\content\browser\accessibility\dump_accessibility_browsertest_base.cc(363):
error: Value of: is_different
  Actual: true
Expected: false
[4988:5300:0523/092002.409:37981750:ERROR:dump_accessibility_browsertest_base.cc(388)]
Diff:
* Line Expected
- ---- --------
*    1 EVENT_OBJECT_VALUECHANGE on role=ROLE_SYSTEM_SLIDER value="2%"
IA2_STATE_EDITABLE,IA2_STATE_VERTICAL
     2 <-- End-of-file -->
Actual
------
EVENT_OBJECT_VALUECHANGE on role=ROLE_SYSTEM_SLIDER value="2%"
IA2_STATE_VERTICAL
<-- End-of-file -->.

[findit-for-me, 2017-05-23 17:18:01]

Findit (https://goo.gl/kROfz5) identified this CL at revision 473911 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[aleventhal, 2017-05-23 17:57:27]

Description was changed from

==========
Why do we have this line when it makes sliders look editable?

BUG=None

Review-Url: https://codereview.chromium.org/2893963002
Cr-Commit-Position: refs/heads/master@{#473911}
Committed:
https://chromium.googlesource.com/chromium/src/+/b78f1ba01120e4f9dfa9faf541b6...
==========

to

==========
Why do we have this line when it makes sliders look editable?

BUG=None

Review-Url: https://codereview.chromium.org/2893963002
Cr-Commit-Position: refs/heads/master@{#473911}
Committed:
https://chromium.googlesource.com/chromium/src/+/b78f1ba01120e4f9dfa9faf541b6...
==========