Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2900883002: Revert of Enable LLD for POSIX LTO builds on Linux. (Closed)

Created:
3 years, 7 months ago by pcc1
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable LLD for POSIX LTO builds on Linux. (patchset #1 id:1 of https://codereview.chromium.org/2877913003/ ) Reason for revert: Breaks crash reporting. BUG=716484 Original issue's description: > Enable LLD for POSIX LTO builds on Linux. > > This is a stripped down version of (reverted) > change: https://codereview.chromium.org/2831213006/ > > That change was reverted because ThinLTO regresses the binary > size too much. LLD was a harmless part of the change, > so it's worth enabling it. > > Based on https://codereview.chromium.org/2844883002/ by > krasin@chromium.org, who is no longer with Google. > > BUG=607968 > R=dpranke@chromium.org,thakis@chromium.org > > Review-Url: https://codereview.chromium.org/2877913003 > Cr-Commit-Position: refs/heads/master@{#471532} > Committed: https://chromium.googlesource.com/chromium/src/+/e6a66337552cfd9a9af9471775ad5b67ee588b88 TBR=dpranke@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=607968 Review-Url: https://codereview.chromium.org/2900883002 Cr-Commit-Position: refs/heads/master@{#473733} Committed: https://chromium.googlesource.com/chromium/src/+/579f0a9f7b3a6428db7ae8aa457fd197ac325fe9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/toolchain/toolchain.gni View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pcc1
Created Revert of Enable LLD for POSIX LTO builds on Linux.
3 years, 7 months ago (2017-05-22 21:31:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900883002/1
3 years, 7 months ago (2017-05-22 21:32:23 UTC) #3
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-22 21:32:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/579f0a9f7b3a6428db7ae8aa457fd197ac325fe9
3 years, 7 months ago (2017-05-22 23:10:24 UTC) #7
pcc1
3 years, 7 months ago (2017-05-26 20:29:40 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2909713002/ by pcc@chromium.org.

The reason for reverting is: Fixes for breakpad bugs that broke crash reporting
have landed: https://codereview.chromium.org/2906093002/.

Powered by Google App Engine
This is Rietveld 408576698